Revert to using firedrake-vanilla docker container #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once asQ could be installed as part of the `firedrake-install` script, I updated the asQ CI to use the Firedrake docker container with asQ installed in #180. This was a mistake, because that docker container installs the master branch of asQ, so since that change the CI on each PR has actually been running with the master branch not the PR branch. Worse, it also hasn't been correct when running the CI on master once each PR has merged, because the docker container has the version of master from whenever the container was built, not the version of when we run it. This PR reverts this change, so we're now back to using the vanilla firedrake docker in the CI, and installing the current branch of asQ before running the tests.
colinjcotter
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once asQ could be installed as part of the
firedrake-installscript, I updated the asQ CI to use the Firedrake docker container with asQ installed in #180.This was a mistake, because that docker container installs the master branch of asQ, so since that change the CI on each PR has actually been running with the master branch not the PR branch. Worse, it also hasn't been correct when running the CI on master once each PR has merged, because the docker container has the version of master from whenever the container was built, not the version of when we run it.
This PR reverts this change, so we're now back to using the vanilla firedrake docker in the CI, and installing the current branch of asQ before running the tests.