Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allatonce function time explicit #125

Merged
merged 23 commits into from
Aug 8, 2023
Merged

Allatonce function time explicit #125

merged 23 commits into from
Aug 8, 2023

Conversation

Abdalaziz-Hamdan
Copy link
Collaborator

Generalizing the allatonce_function branch to apply to time-dependent PDEs.

@JHopeCollins JHopeCollins changed the base branch from master to allatonce_function July 6, 2023 11:41
JHopeCollins
JHopeCollins requested changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part! I'm not sure yet about storing the values of time at the initial condition and each timestep seperately though - I've added comments explaining.

asQ/allatonce/function.py Outdated Show resolved Hide resolved
asQ/paradiag.py Outdated Show resolved Hide resolved
tests/allatonce/test_allatonceform.py Outdated Show resolved Hide resolved
tests/allatonce/test_allatonceform.py Outdated Show resolved Hide resolved
tests/allatonce/test_allatoncejacobian.py Outdated Show resolved Hide resolved
tests/allatonce/test_allatoncejacobian.py Outdated Show resolved Hide resolved
tests/test_paradiag.py Show resolved Hide resolved
@JHopeCollins JHopeCollins added enhancement New feature or request Core functionality Adding to the main paradiag functionality labels Jul 10, 2023
JHopeCollins
JHopeCollins requested changes Jul 10, 2023
View reviewed changes
asQ/allatonce/form.py Outdated Show resolved Hide resolved
JHopeCollins
JHopeCollins requested changes Jul 10, 2023
View reviewed changes
asQ/diag_preconditioner.py Outdated Show resolved Hide resolved
JHopeCollins
JHopeCollins requested changes Jul 11, 2023
View reviewed changes
asQ/allatonce/form.py Show resolved Hide resolved
JHopeCollins
JHopeCollins requested changes Jul 14, 2023
View reviewed changes
asQ/allatonce/form.py Outdated Show resolved Hide resolved
tests/allatonce/test_allatonceform.py Outdated Show resolved Hide resolved
JHopeCollins
JHopeCollins requested changes Jul 14, 2023
View reviewed changes
asQ/allatonce/form.py Outdated Show resolved Hide resolved
tests/allatonce/test_allatonceform.py Show resolved Hide resolved
tests/allatonce/test_allatonceform.py Outdated Show resolved Hide resolved
tests/allatonce/test_allatonceform.py Outdated Show resolved Hide resolved
tests/allatonce/test_allatonceform.py Show resolved Hide resolved
JHopeCollins
JHopeCollins reviewed Jul 24, 2023
View reviewed changes
asQ/allatonce/form.py Outdated Show resolved Hide resolved
@JHopeCollins JHopeCollins merged commit 1e05aeb into allatonce_function Aug 8, 2023
1 check passed
@JHopeCollins JHopeCollins deleted the allatonce_function_time_explicit branch August 8, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JHopeCollins JHopeCollins JHopeCollins approved these changes

@colinjcotter colinjcotter Awaiting requested review from colinjcotter

Assignees
No one assigned
Labels
Core functionality Adding to the main paradiag functionality enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdalaziz-Hamdan @JHopeCollins