Column type icon matches the datatype type of the field in column selectors (where, group by, sortby, filter) #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agging to new column selector Signed-off-by: Tarek Quao <[email protected]>
Signed-off-by: Tarek Quao <[email protected]>
texodus
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Thanks for the PR! A few notes to keep in mind for future PRs:
- We normally ask for a unit test with all PRs, but this is relatively minor so I'll let it slide. For the record though, testing this should be quite easy - just set up a viewer with a config and check the DOM output (many of our
perspective-viewertests do this already e.g.). - Watch for ☠️ dead code ☠️ please, there's no point in leaving commented-out code when we have the project history on GitHub.
- Generally prefer not to use
.expect()in Perspective WASM code, as it leads to bad errors when an expectation is missed (sometimes generations after your PR is merged).
| @@ -456,6 +456,8 @@ impl Component for FilterColumn { | |||
| } | |||
| .unwrap_or_default(); | |||
|
|
|||
| let final_col_type = col_type.expect("Unknown column"); | |||
There was a problem hiding this comment.
There is no point in using expect() in Perspective WASM code because the error message does not propagate to the JS console. Generally we want to safely handle when this is missing because panic! leads to a frozen/broken web app that has to be refreshed.
| @@ -465,7 +467,8 @@ impl Component for FilterColumn { | |||
| > | |||
| <LocalStyle href={css!("filter-item")} /> | |||
| <div class="pivot-column-border"> | |||
| <TypeIcon ty={ColumnType::String} /> | |||
| // <TypeIcon ty={ColumnType::String} /> | |||
| @@ -10,18 +10,20 @@ | |||
| // ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃ | |||
| // ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ | |||
|
|
|||
| use perspective_client::ColumnType; | |||
| // use perspective_client::ColumnType; | |||
| @@ -69,7 +78,8 @@ impl Component for PivotColumn { | |||
| ondragend={dragend} | |||
| > | |||
| <div class="pivot-column-border"> | |||
| <TypeIcon ty={ColumnType::String} /> | |||
| <TypeIcon ty={col_type} /> | |||
| // <TypeIcon ty={ColumnType::String} /> | |||
| @@ -11,7 +11,7 @@ | |||
| // ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ | |||
|
|
|||
| use perspective_client::config::*; | |||
| use perspective_client::ColumnType; | |||
| // use perspective_client::ColumnType; | |||
onesimus-wiafe
pushed a commit
to onesimus-wiafe/perspective
that referenced
this pull request
Oct 18, 2024
Column type icon matches the datatype type of the field in column selectors (where, group by, sortby, filter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of icons of columns defaulting to string icon instead of the right data type in issue #2580