Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix template dropdown overflow issue #3613

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented Oct 17, 2024

Summary

fix template dropdown overflow issue

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

before:

Screenshot 2024-10-17 at 5 25 20 PM

after:

Screenshot 2024-10-17 at 5 25 41 PM

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner October 17, 2024 21:26
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 4336a71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-application-query-deployment Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.37%. Comparing base (5f661e5) to head (4336a71).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
+ Coverage   45.36%   45.37%   +0.01%     
==========================================
  Files        2168     2168              
  Lines      374668   374668              
  Branches    10790    16025    +5235     
==========================================
+ Hits       169963   170009      +46     
+ Misses     204014   203968      -46     
  Partials      691      691              

see 35 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit d5a5e0b into finos:master Oct 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants