Skip to content

Commit

Permalink
cleanup un-isolated sass code (#3477)
Browse files Browse the repository at this point in the history
  • Loading branch information
akphi authored Aug 28, 2024
1 parent 2770a48 commit fbeeb38
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 21 deletions.
4 changes: 4 additions & 0 deletions .changeset/twenty-oranges-thank.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
'@finos/legend-extension-dsl-data-space-studio': patch
'@finos/legend-application-repl-deployment': patch
---
33 changes: 13 additions & 20 deletions packages/legend-application-repl-deployment/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,36 +2,29 @@

This is the `Legend REPL` web application deployment. This is used for development locally

## Backend
## Getting Started

`Legend REPL` relies on:
1. Start the REPL using [this guide](https://github.com/finos/legend-engine/blob/master/legend-engine-config/legend-engine-repl/README.md#developer-guide).

- [Legend Engine](https://github.com/finos/legend-engine) [REPL Client](https://github.com/finos/legend-engine/blob/master/legend-engine-config/legend-engine-repl/legend-engine-repl-relational/src/main/java/org/finos/legend/engine/repl/relational/client/RClient.java).
- Use [DataCubeClient](https://github.com/finos/legend-engine/blob/master/legend-engine-config/legend-engine-repl/legend-engine-repl-data-cube/src/main/java/org/finos/legend/engine/repl/dataCube/client/DataCubeClient.java).
- Make sure to configure the properties to have the REPL point at the DEV web app:

## Getting started

To quickly setup the backend, spin up `REPL Client` application:

- In order to start the server, please use the `Main` class `org.finos.legend.engine.repl.relational.client.RClient`
- This will open a new terminal in your IDE with REPL Client up and running. This will also print the port at which backend server for grid is running at.
- If you wish to change the port for backend server (preferably 8080 as client assumes server runs at this port) please modify port here [REPL Grid Server](https://github.com/finos/legend-engine/blob/master/legend-engine-config/legend-engine-repl/legend-engine-repl-relational/src/main/java/org/finos/legend/engine/repl/relational/httpServer/ReplGridServer.java)

Before spinning up the application make sure to run these commands on `REPL terminal` so that there is an initial query state for grid.

```bash
load <path> <connection>
#>{<db.table>}#->from(<connection>)
show
```
# [DEVELOPMENT] Specify the base URL for the development instance of the web application
# this is needed to bypass CORS
-Dlegend.repl.dataCube.devWebAppBaseUrl=http://localhost:9005
To know about more specific synatx of these commands type `help` on the REPL terminal.
# [DEVELOPMENT] By default, the port is randomized, but for development, the port needs
# to be fixed to allow the web application to connect to the REPL
-Dlegend.repl.dataCube.devPort=9006
```

Last but not least, make sure you have `Yarn` installed. Run the following commands in order.
2. Start REPL web-application:

```bash
yarn install
yarn setup
yarn dev:repl
```

After setting up, visit http://localhost:9005/repl/grid and the application should be up and running.
Visit http://localhost:9005/repl/grid and the application should be up and running.
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
* limitations under the License.
*/
@forward 'data-space-template-query-promotor';
@forward './editor/dataSpace/data-space-editor';
@forward 'data-space-editor';

0 comments on commit fbeeb38

Please sign in to comment.