datacube: componentization (#3556)

* datacube: reorganize states * datacube: componentize datacube * repl: slim down application boilerplate * establish @finos/legend-data-cube package * refactor: move core code-editor support logic to @finos/legend-code-editor * datacube: enable pagination by default * datacube: cleanup unnecessary deps * datacube: reorganize application engine * datacube: separate datacube from REPL code * move datacube to @finos/legend-data-cube * add changeset * bump dependencies
finos · Sep 26, 2024 · 12ea153 · 12ea153
1 parent ea6c454
commit 12ea153
Show file tree

Hide file tree

Showing 307 changed files with 2,619 additions and 2,861 deletions.
diff --git a/.changeset/angry-geckos-tease.md b/.changeset/angry-geckos-tease.md
@@ -0,0 +1,19 @@
+---
+'@finos/legend-extension-dsl-data-space-studio': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-extension-dsl-data-quality': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-extension-assortment': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-data-cube': patch
+'@finos/legend-lego': patch
+---
diff --git a/.changeset/flat-kangaroos-roll.md b/.changeset/flat-kangaroos-roll.md
@@ -0,0 +1,22 @@
+---
+'@finos/legend-extension-dsl-data-space-studio': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-extension-dsl-data-quality': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-extension-assortment': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-application': patch
+'@finos/legend-code-editor': patch
+'@finos/legend-data-cube': patch
+'@finos/legend-shared': patch
+'@finos/legend-lego': patch
+---
diff --git a/.changeset/fresh-news-invent.md b/.changeset/fresh-news-invent.md
@@ -0,0 +1,5 @@
+---
+'@finos/legend-application-repl': major
+---
+
+**BREAKING CHANGE:** Separate core DataCube code to `@finos/legend-data-cube`
diff --git a/.changeset/great-apples-love.md b/.changeset/great-apples-love.md
@@ -0,0 +1,20 @@
+---
+'@finos/legend-extension-dsl-data-space-studio': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-extension-dsl-data-quality': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-extension-assortment': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-code-editor': patch
+'@finos/legend-data-cube': patch
+'@finos/legend-lego': patch
+---
diff --git a/.changeset/hip-tables-wonder.md b/.changeset/hip-tables-wonder.md
@@ -12,7 +12,7 @@
 '@finos/legend-extension-dsl-persistence': patch
 '@finos/legend-extension-store-flat-data': patch
 '@finos/legend-extension-dsl-data-space': patch
-'@finos/legend-application-data-cube': patch
+'@finos/legend-data-cube': patch
 '@finos/legend-extension-dsl-diagram': patch
 '@finos/legend-extension-dsl-service': patch
 '@finos/legend-application-pure-ide': patch

diff --git a/.changeset/kind-carrots-refuse.md b/.changeset/kind-carrots-refuse.md
@@ -0,0 +1,22 @@
+---
+'@finos/legend-extension-dsl-data-space-studio': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-extension-dsl-data-quality': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-extension-assortment': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-application': patch
+'@finos/legend-code-editor': patch
+'@finos/legend-data-cube': patch
+'@finos/legend-shared': patch
+'@finos/legend-lego': patch
+---
diff --git a/.changeset/lazy-lemons-warn.md b/.changeset/lazy-lemons-warn.md
@@ -0,0 +1,5 @@
+---
+'@finos/legend-lego': major
+---
+
+**BREAKING CHANGE:** Split core code editor utilities (theming, Pure language support, etc.) which are not dependent on `@finos/legend-application` to `@finos/legend-code-editor`.
diff --git a/.changeset/rich-dolls-protect.md b/.changeset/rich-dolls-protect.md
@@ -12,7 +12,7 @@
 '@finos/legend-extension-dsl-persistence': patch
 '@finos/legend-extension-store-flat-data': patch
 '@finos/legend-extension-dsl-data-space': patch
-'@finos/legend-application-data-cube': patch
+'@finos/legend-data-cube': patch
 '@finos/legend-extension-dsl-diagram': patch
 '@finos/legend-extension-dsl-service': patch
 '@finos/legend-application-pure-ide': patch

diff --git a/.changeset/rude-suns-hope.md b/.changeset/rude-suns-hope.md
@@ -0,0 +1,34 @@
+---
+'@finos/legend-application-pure-ide-deployment': patch
+'@finos/legend-extension-dsl-data-space-studio': patch
+'@finos/legend-application-studio-deployment': patch
+'@finos/legend-extension-store-service-store': patch
+'@finos/legend-vscode-extension-dependencies': patch
+'@finos/legend-application-query-deployment': patch
+'@finos/legend-application-repl-deployment': patch
+'@finos/legend-extension-dsl-data-quality': patch
+'@finos/legend-extension-store-relational': patch
+'@finos/legend-server-showcase-deployment': patch
+'@finos/legend-extension-dsl-persistence': patch
+'@finos/legend-extension-store-flat-data': patch
+'@finos/legend-extension-dsl-data-space': patch
+'@finos/legend-extension-dsl-diagram': patch
+'@finos/legend-extension-dsl-service': patch
+'@finos/legend-application-pure-ide': patch
+'@finos/legend-extension-assortment': patch
+'@finos/legend-application-studio': patch
+'@finos/legend-extension-dsl-text': patch
+'@finos/legend-application-query': patch
+'@finos/legend-application-repl': patch
+'@finos/legend-server-showcase': patch
+'@finos/legend-query-builder': patch
+'@finos/legend-application': patch
+'@finos/legend-code-editor': patch
+'@finos/legend-server-sdlc': patch
+'@finos/legend-data-cube': patch
+'@finos/legend-dev-utils': patch
+'@finos/legend-shared': patch
+'@finos/legend-graph': patch
+'@finos/legend-lego': patch
+'@finos/legend-art': patch
+---
diff --git a/.changeset/silver-pugs-study.md b/.changeset/silver-pugs-study.md
@@ -1,4 +1,4 @@
 ---
-'@finos/legend-application-data-cube': patch
+'@finos/legend-data-cube': patch
 '@finos/legend-application-repl': patch
 ---
diff --git a/.changeset/spotty-bobcats-flow.md b/.changeset/spotty-bobcats-flow.md
@@ -0,0 +1,5 @@
+---
+'@finos/legend-application': major
+---
+
+**BREAKING CHANGE:** Move `DocumentationEntry` to `@finos/legend-shared`.
diff --git a/package.json b/package.json
@@ -99,7 +99,7 @@
  "@finos/eslint-plugin-legend-studio": "workspace:*",
  "@finos/legend-dev-utils": "workspace:*",
  "@finos/stylelint-config-legend-studio": "workspace:*",
- "@types/node": "22.7.0",
+ "@types/node": "22.7.2",
  "chalk": "5.3.0",
  "cross-env": "7.0.3",
  "envinfo": "7.14.0",

diff --git a/packages/legend-application-data-cube/CHANGELOG.md b/packages/legend-application-data-cube/CHANGELOG.md
diff --git a/packages/legend-application-data-cube/README.md b/packages/legend-application-data-cube/README.md
diff --git a/packages/legend-application-data-cube/style/data-cube.scss b/packages/legend-application-data-cube/style/data-cube.scss
diff --git a/packages/legend-application-pure-ide-deployment/package.json b/packages/legend-application-pure-ide-deployment/package.json
@@ -53,7 +53,7 @@
  "npm-run-all": "4.1.5",
  "rimraf": "6.0.1",
  "typescript": "5.6.2",
- "webpack": "5.94.0",
+ "webpack": "5.95.0",
  "webpack-bundle-analyzer": "4.10.2",
  "webpack-cli": "5.1.4",
  "webpack-dev-server": "5.1.0"

diff --git a/packages/legend-application-pure-ide/package.json b/packages/legend-application-pure-ide/package.json
@@ -45,13 +45,14 @@
  "dependencies": {
  "@finos/legend-application": "workspace:*",
  "@finos/legend-art": "workspace:*",
+ "@finos/legend-code-editor": "workspace:*",
  "@finos/legend-extension-dsl-diagram": "workspace:*",
  "@finos/legend-graph": "workspace:*",
  "@finos/legend-lego": "workspace:*",
  "@finos/legend-shared": "workspace:*",
  "@types/react": "18.3.9",
  "@types/react-dom": "18.3.0",
- "mobx": "6.13.2",
+ "mobx": "6.13.3",
  "mobx-react-lite": "4.0.7",
  "monaco-editor": "0.52.0",
  "react": "18.3.1",

diff --git a/packages/legend-application-pure-ide/src/components/Core_LegendPureIDEApplicationPlugin.tsx b/packages/legend-application-pure-ide/src/components/Core_LegendPureIDEApplicationPlugin.tsx
@@ -27,10 +27,8 @@ import {
  LEGEND_PURE_IDE_PURE_FILE_EDITOR_COMMAND_CONFIG,
 } from '../__lib__/LegendPureIDECommand.js';
 import { PURE_GRAMMAR_DIAGRAM_ELEMENT_TYPE_LABEL } from '../stores/PureFileEditorUtils.js';
-import {
- configureCodeEditorComponent,
- setupPureLanguageService,
-} from '@finos/legend-lego/code-editor';
+import { setupPureLanguageService } from '@finos/legend-code-editor';
+import { configureCodeEditorComponent } from '@finos/legend-lego/code-editor';
 
 export class Core_LegendPureIDEApplicationPlugin extends LegendPureIDEApplicationPlugin {
  static NAME = packageJson.extensions.applicationPureIDEPlugin;

diff --git a/packages/legend-application-pure-ide/src/components/editor-group/EditorGroup.tsx b/packages/legend-application-pure-ide/src/components/editor-group/EditorGroup.tsx
@@ -31,7 +31,7 @@ import { DiagramEditor } from './DiagramEditor.js';
 import { usePureIDEStore } from '../PureIDEStoreProvider.js';
 import { PURE_DiagramIcon } from '../shared/ConceptIconUtils.js';
 import { TabManager, type TabState } from '@finos/legend-lego/application';
-import { CODE_EDITOR_LANGUAGE } from '@finos/legend-lego/code-editor';
+import { CODE_EDITOR_LANGUAGE } from '@finos/legend-code-editor';
 
 const EditorGroupSplashScreen: React.FC = () => {
  const commandListWidth = 300;

diff --git a/packages/legend-application-pure-ide/src/components/editor-group/GenericFileEditor.tsx b/packages/legend-application-pure-ide/src/components/editor-group/GenericFileEditor.tsx
@@ -31,7 +31,7 @@ import {
  CODE_EDITOR_THEME,
  getBaseCodeEditorOptions,
  moveCursorToPosition,
-} from '@finos/legend-lego/code-editor';
+} from '@finos/legend-code-editor';
 
 const POSITION_PATTERN = /[0-9]+(?::[0-9]+)?/;
 

diff --git a/packages/legend-application-pure-ide/src/components/editor-group/PureFileEditor.tsx b/packages/legend-application-pure-ide/src/components/editor-group/PureFileEditor.tsx
@@ -39,7 +39,7 @@ import {
  getBaseCodeEditorOptions,
  moveCursorToPosition,
  PURE_CODE_EDITOR_WORD_SEPARATORS,
-} from '@finos/legend-lego/code-editor';
+} from '@finos/legend-code-editor';
 import { clsx, Dialog, WordWrapIcon } from '@finos/legend-art';
 import { usePureIDEStore } from '../PureIDEStoreProvider.js';
 import {

diff --git a/packages/legend-application-pure-ide/src/components/panel-group/TestRunnerPanel.tsx b/packages/legend-application-pure-ide/src/components/panel-group/TestRunnerPanel.tsx
@@ -81,9 +81,9 @@ import {
 import {
  CODE_EDITOR_LANGUAGE,
  CODE_EDITOR_THEME,
- disposeCodeEditor,
- getBaseConsoleOptions,
-} from '@finos/legend-lego/code-editor';
+ getBaseCodeEditorOptions,
+} from '@finos/legend-code-editor';
+import { disposeCodeEditor } from '@finos/legend-lego/code-editor';
 
 const TestTreeNodeContainer = observer(
  (
@@ -360,7 +360,26 @@ const TestResultConsole: React.FC<{
  if (!editor && textInputRef.current) {
  const element = textInputRef.current;
  const newEditor = monacoEditorAPI.create(element, {
- ...getBaseConsoleOptions(),
+ ...getBaseCodeEditorOptions(),
+ fontSize: 12,
+ extraEditorClassName: 'monaco-editor--small-font',
+ readOnly: true,
+ glyphMargin: false,
+ folding: false,
+ lineNumbers: 'off',
+ lineDecorationsWidth: 10,
+ lineNumbersMinChars: 0,
+ minimap: {
+ enabled: false,
+ },
+ guides: {
+ bracketPairs: false,
+ bracketPairsHorizontal: false,
+ highlightActiveBracketPair: false,
+ indentation: false,
+ highlightActiveIndentation: false,
+ },
+ renderLineHighlight: 'none',
  theme: CODE_EDITOR_THEME.DEFAULT_DARK,
  language: CODE_EDITOR_LANGUAGE.TEXT,
  });

diff --git a/packages/legend-application-pure-ide/src/stores/FileEditorState.ts b/packages/legend-application-pure-ide/src/stores/FileEditorState.ts
@@ -24,7 +24,7 @@ import {
  setErrorMarkers,
  type CodeEditorPosition,
  CODE_EDITOR_LANGUAGE,
-} from '@finos/legend-lego/code-editor';
+} from '@finos/legend-code-editor';
 import { DIRECTORY_PATH_DELIMITER } from '@finos/legend-graph';
 import {
  assertErrorThrown,

diff --git a/packages/legend-application-pure-ide/src/stores/PureFileEditorUtils.ts b/packages/legend-application-pure-ide/src/stores/PureFileEditorUtils.ts
@@ -19,7 +19,7 @@ import {
  CODE_EDITOR_LANGUAGE,
  isTokenOneOf,
  PURE_GRAMMAR_TOKEN,
-} from '@finos/legend-lego/code-editor';
+} from '@finos/legend-code-editor';
 import {
  ELEMENT_PATH_DELIMITER,
  extractElementNameFromPath,

diff --git a/packages/legend-application-pure-ide/tsconfig.build.json b/packages/legend-application-pure-ide/tsconfig.build.json
@@ -11,6 +11,7 @@
  { "path": "../legend-shared/tsconfig.build.json" },
  { "path": "../legend-application/tsconfig.build.json" },
  { "path": "../legend-art/tsconfig.build.json" },
+ { "path": "../legend-code-editor/tsconfig.build.json" },
  { "path": "../legend-lego/tsconfig.build.json" },
  { "path": "../legend-extension-dsl-diagram/tsconfig.build.json" }
  ]

diff --git a/packages/legend-application-pure-ide/tsconfig.json b/packages/legend-application-pure-ide/tsconfig.json
@@ -13,6 +13,7 @@
  { "path": "../legend-shared" },
  { "path": "../legend-application" },
  { "path": "../legend-art" },
+ { "path": "../legend-code-editor" },
  { "path": "../legend-lego" },
  { "path": "../legend-extension-dsl-diagram" }
  ]

diff --git a/packages/legend-application-query-deployment/package.json b/packages/legend-application-query-deployment/package.json
@@ -44,7 +44,7 @@
  "npm-run-all": "4.1.5",
  "rimraf": "6.0.1",
  "typescript": "5.6.2",
- "webpack": "5.94.0",
+ "webpack": "5.95.0",
  "webpack-bundle-analyzer": "4.10.2",
  "webpack-cli": "5.1.4",
  "webpack-dev-server": "5.1.0"

diff --git a/packages/legend-application-query/package.json b/packages/legend-application-query/package.json
@@ -45,6 +45,7 @@
  "dependencies": {
  "@finos/legend-application": "workspace:*",
  "@finos/legend-art": "workspace:*",
+ "@finos/legend-code-editor": "workspace:*",
  "@finos/legend-extension-dsl-data-space": "workspace:*",
  "@finos/legend-graph": "workspace:*",
  "@finos/legend-lego": "workspace:*",
@@ -56,7 +57,7 @@
  "@testing-library/react": "16.0.1",
  "@types/react": "18.3.9",
  "@types/react-dom": "18.3.0",
- "mobx": "6.13.2",
+ "mobx": "6.13.3",
  "mobx-react-lite": "4.0.7",
  "react": "18.3.1",
  "react-dom": "18.3.1",

diff --git a/packages/legend-application-query/src/components/Core_LegendQueryApplicationPlugin.tsx b/packages/legend-application-query/src/components/Core_LegendQueryApplicationPlugin.tsx
@@ -59,10 +59,7 @@ import { CloneQueryServiceSetup } from './CloneQueryServiceSetup.js';
 import { QueryProductionizerSetup } from './QueryProductionizerSetup.js';
 import { UpdateExistingServiceQuerySetup } from './UpdateExistingServiceQuerySetup.js';
 import { LoadProjectServiceQuerySetup } from './LoadProjectServiceQuerySetup.js';
-import {
- configureCodeEditorComponent,
- setupPureLanguageService,
-} from '@finos/legend-lego/code-editor';
+import { setupPureLanguageService } from '@finos/legend-code-editor';
 import {
  generateDataSpaceQueryCreatorRoute,
  generateDataSpaceQuerySetupRoute,
@@ -89,6 +86,7 @@ import { QueryEditorExistingQueryHeader } from './QueryEditor.js';
 import { DataSpaceTemplateQueryCreatorStore } from '../stores/data-space/DataSpaceTemplateQueryCreatorStore.js';
 import { createViewSDLCProjectHandler } from '../stores/data-space/DataSpaceQueryBuilderHelper.js';
 import { DataSpaceQueryCreatorStore } from '../stores/data-space/DataSpaceQueryCreatorStore.js';
+import { configureCodeEditorComponent } from '@finos/legend-lego/code-editor';
 
 export class Core_LegendQueryApplicationPlugin extends LegendQueryApplicationPlugin {
  static NAME = packageJson.extensions.applicationQueryPlugin;

diff --git a/packages/legend-application-query/tsconfig.build.json b/packages/legend-application-query/tsconfig.build.json
@@ -15,6 +15,7 @@
  { "path": "../legend-extension-dsl-data-space/tsconfig.build.json" },
  { "path": "../legend-query-builder/tsconfig.build.json" },
  { "path": "../legend-art/tsconfig.build.json" },
+ { "path": "../legend-code-editor/tsconfig.build.json" },
  { "path": "../legend-lego/tsconfig.build.json" }
  ]
 }
diff --git a/packages/legend-application-query/tsconfig.json b/packages/legend-application-query/tsconfig.json
@@ -17,6 +17,7 @@
  { "path": "../legend-query-builder" },
  { "path": "../legend-extension-dsl-data-space" },
  { "path": "../legend-art" },
+ { "path": "../legend-code-editor" },
  { "path": "../legend-lego" }
  ]
 }