Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not evaluate default value constructors #3174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not evaluate default value constructors #3174

wants to merge 2 commits into from

Conversation

mateusz-klatt
Copy link
Member

@mateusz-klatt mateusz-klatt commented Oct 13, 2024 •
edited
Loading

What type of PR is this?

  • Improvement

What does this PR do / why is it needed?

  • Use reflection in diff generator to find out arguments to constructors, so the is no need to compile Java Impl classes for Pure entities.
  • Improve Change Tokens development cycle, allow to test code in Pure IDE (move unit tests from Java to Pure)

Other notes for reviewers:

Pending regression checks in integration enviroment.

@mateusz-klatt mateusz-klatt requested a review from a team as a code owner October 13, 2024 01:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

Test Results

     994 files   -   44       994 suites   - 44   1h 29m 4s ⏱️ + 1m 44s
12 189 tests  - 156  12 099 ✔️  - 156  90 💤 ±0  0 ❌ ±0 
18 141 runs  +    1  18 051 ✔️ +    1  90 💤 ±0  0 ❌ ±0 

Results for commit 64575a0. ± Comparison against base commit 7fe40bf.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mateusz-klatt