use parallelMap in PureToSql #3098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelbey
reviewed
Sep 17, 2024
| { | ||
| this.tracer = tracer; | ||
| this.modelLoaders = Lists.mutable.of(modelLoaders); | ||
| this.modelLoaders.forEach((Procedure<ModelLoader>) loader -> loader.setModelManager(this)); | ||
| this.deploymentMode = mode; | ||
| this.forkJoinPool = forkJoinPool; | ||
| this.executorService = executorService; |
There was a problem hiding this comment.
If we go with this approach, we should not have two pools.
|
This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Setup code to leverage parallelMap in Engine.
Use parallelMap in PureToSql processProject to improve performance.
Which issue(s) this PR fixes:
Fixes #
Other notes for reviewers:
Does this PR introduce a user-facing change?