Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when reloading page with parameters in URL #229

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SteffeyDev
Copy link

This was a fun one to track down.

First off, thanks for making and maintaining Pager, we use it on a fairly large web app (~30 pages) and haven't had too many issues so far. However, we did run into an issue that when you reload a nested page that has query params attached, it never loaded the page. I tracked down the bug to be on line 818. The issue was that the page being loaded (m.getId()) was Ticket, but the parent.route[0] was Ticket?uid=<guid>, so because those did not match it did not trigger parent.showPage and thus the page was never shown.

This fix is pretty straight forward, and I would appreciate if you can merge into the next release and let me know when it goes out on NPM so I can switch our project back to using this repo instead of my fork. Let me know if you want me to make any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant