feat: FFI_PORTABLE to build a maximally portable binary #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: filecoin-project/lotus#12423
Background: we're having trouble building from source in Lotus CI because we run tests two different machine types and only build FFI on one, caching the output and deploying it on the other machines. We have our own custom runners in AWS and also lean heavily on the default GHA runners which are in Azure and they obviously have different CPU types.
This change introduces
FFI_PORTABLE=1
which builds using the same flags as rust/scripts/build-release.sh does when called from CI to build the release bundle.Comparison of some builds:
When run from CI, we get:
When run from
FFI_BUILD_FROM_SOURCE=1 make
(on my machine), we get:FFI_BUILD_FROM_SOURCE=1 FFI_USE_BLST_PORTABLE=1 make
gives:And this new option,
FFI_BUILD_FROM_SOURCE=1 FFI_PORTABLE=1 make
, gives:i.e. the same to the CI version except for
--verbose
.