Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding table actions header cell new hook class #14170

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

Crowly34
Copy link

@Crowly34 Crowly34 commented Sep 6, 2024

Description

Adding an additional hook class for the action table cell header to make it easy to add my own custom theme, I followed the structure of the others, we could also just use fi-ta-header-cell, I'm open to suggestions

@Crowly34 Crowly34 changed the title Adding new hook class Adding table actions header cell new hook class Sep 6, 2024
@Crowly34 Crowly34 marked this pull request as ready for review September 6, 2024 21:30
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few other places where this will also need applying, like on the header-cell above when the cell has a label, and for the other action column positions (before columns, after columns)

Also I think it should be fi-ta-actions-header-cell as per fi-ta-summary-header-cell

@danharrin danharrin added the enhancement New feature or request label Sep 8, 2024
@danharrin danharrin added this to the v3 milestone Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants