FI-202: Refactor Validation

.gitignore

@@ -8,3 +8,9 @@ tmp/
 
 # User-specific
 .idea
+
+## Documentation cache and generated files:
+/.yardoc/
+/_yardoc/
+/doc/
+/rdoc/

.rubocop.yml

@@ -1,9 +1,9 @@
+require: rubocop-rspec
 inherit_from: .rubocop_todo.yml
 AllCops:
   TargetRubyVersion: 2.4
   Exclude:
     - 'test/**/*'
-    - 'spec/**/*'
     - 'lib/fhir_models/fhir/**/*'
     - 'lib/fhir_models/fluentpath/evaluate.rb'
     - 'lib/**/*.rake'
@@ -17,3 +17,10 @@ Style/FrozenStringLiteralComment:
 inherit_mode:
   merge:
     - Exclude
+Naming/RescuedExceptionsVariableName:
+  PreferredName: 'e'
+RSpec/FilePath:
+  Enabled: false
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*.rb'

.rubocop_todo.yml

@@ -1,24 +1,21 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-04-22 22:20:52 -0400 using RuboCop version 0.67.0.
+# on 2019-08-14 09:13:47 -0400 using RuboCop version 0.67.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 51
+# Offense count: 40
 # Cop supports --auto-correct.
 Layout/EmptyLineAfterGuardClause:
   Exclude:
     - 'lib/fhir_models/bootstrap/definitions.rb'
     - 'lib/fhir_models/bootstrap/generator.rb'
     - 'lib/fhir_models/bootstrap/hashable.rb'
-    - 'lib/fhir_models/bootstrap/model.rb'
     - 'lib/fhir_models/bootstrap/preprocess.rb'
     - 'lib/fhir_models/bootstrap/xml.rb'
     - 'lib/fhir_models/deprecate.rb'
-    - 'lib/fhir_models/fhir_ext/element_definition.rb'
-    - 'lib/fhir_models/fhir_ext/structure_definition.rb'
     - 'lib/fhir_models/fhir_ext/structure_definition_compare.rb'
     - 'lib/fhir_models/fluentpath/parse.rb'
 
@@ -35,53 +32,49 @@ Lint/ToJSON:
     - 'lib/fhir_models/bootstrap/json.rb'
     - 'lib/fhir_models/fhir_ext/structure_definition_finding.rb'
 
-# Offense count: 40
+# Offense count: 34
 Metrics/AbcSize:
   Max: 392
 
-# Offense count: 7
+# Offense count: 5
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 74
+  Max: 68
 
-# Offense count: 8
+# Offense count: 1
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
-  Max: 5
+  Max: 4
 
-# Offense count: 7
+# Offense count: 6
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 354
+  Max: 269
 
-# Offense count: 23
+# Offense count: 16
 Metrics/CyclomaticComplexity:
   Max: 65
 
-# Offense count: 44
+# Offense count: 37
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 131
+  Max: 109
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
   Max: 114
 
-# Offense count: 23
+# Offense count: 15
 Metrics/PerceivedComplexity:
   Max: 68
 
-# Offense count: 5
+# Offense count: 1
 # Configuration parameters: PreferredName.
 Naming/RescuedExceptionsVariableName:
   Exclude:
     - 'lib/fhir_models/bootstrap/hashable.rb'
-    - 'lib/fhir_models/bootstrap/json.rb'
-    - 'lib/fhir_models/bootstrap/xml.rb'
-    - 'lib/fhir_models/fhir_ext/structure_definition.rb'
-    - 'lib/fhir_models/fhir_ext/structure_definition_finding.rb'
 
 # Offense count: 4
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
@@ -102,7 +95,81 @@ Performance/InefficientHashSearch:
   Exclude:
     - 'lib/fhir_models/bootstrap/template.rb'
 
-# Offense count: 1
+# Offense count: 31
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/lib/fhir_models/fhir_spec.rb'
+    - 'spec/unit/bootstrap/definitions_spec.rb'
+
+# Offense count: 3
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/lib/fhir_models/bootstrap/model_spec.rb'
+    - 'spec/lib/fhir_models/fhir_ext/structure_definition_spec.rb'
+    - 'spec/lib/fhir_models/fhir_spec.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: SkipBlocks, EnforcedStyle.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'spec/unit/bootstrap/definitions_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: CustomIncludeMethods.
+RSpec/EmptyExampleGroup:
+  Exclude:
+    - 'spec/lib/fhir_models/fhir_ext/structure_definition_spec.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+RSpec/EmptyLineAfterExampleGroup:
+  Exclude:
+    - 'spec/lib/fhir_models/fhir_spec.rb'
+
+# Offense count: 31
+# Cop supports --auto-correct.
+RSpec/EmptyLineAfterFinalLet:
+  Exclude:
+    - 'spec/lib/fhir_models/fhir_spec.rb'
+
+# Offense count: 6
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/lib/fhir_models/bootstrap/model_spec.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: CustomTransform, IgnoredWords.
+RSpec/ExampleWording:
+  Exclude:
+    - 'spec/lib/fhir_models/bootstrap/model_spec.rb'
+
+# Offense count: 5
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 3
+
+# Offense count: 121
+# Configuration parameters: IgnoreSharedExamples.
+RSpec/NamedSubject:
+  Exclude:
+    - 'spec/lib/fhir_models/fhir_spec.rb'
+
+# Offense count: 28
+RSpec/NestedGroups:
+  Max: 4
+
+# Offense count: 2
+RSpec/RepeatedDescription:
+  Exclude:
+    - 'spec/lib/fhir_models/fhir_spec.rb'
+
+# Offense count: 25
 # Configuration parameters: .
 # SupportedStyles: inline, group
 Style/AccessModifierDeclarations:
@@ -114,11 +181,10 @@ Style/ClassVars:
     - 'lib/fhir_models/bootstrap/definitions.rb'
     - 'lib/fhir_models/fluentpath/parse.rb'
 
-# Offense count: 6
+# Offense count: 4
 Style/CommentedKeyword:
   Exclude:
     - 'lib/fhir_models/bootstrap/hashable.rb'
-    - 'lib/fhir_models/bootstrap/model.rb'
 
 # Offense count: 14
 Style/Documentation:
@@ -140,7 +206,7 @@ Style/Documentation:
     - 'lib/fhir_models/fluentpath/expression.rb'
     - 'lib/fhir_models/fluentpath/parse.rb'
 
-# Offense count: 29
+# Offense count: 24
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Exclude:
@@ -149,7 +215,6 @@ Style/IfUnlessModifier:
     - 'lib/fhir_models/bootstrap/model.rb'
     - 'lib/fhir_models/bootstrap/template.rb'
     - 'lib/fhir_models/bootstrap/xml.rb'
-    - 'lib/fhir_models/fhir_ext/structure_definition.rb'
     - 'lib/fhir_models/fhir_ext/structure_definition_compare.rb'
 
 # Offense count: 1
@@ -162,13 +227,11 @@ Style/MissingRespondToMissing:
   Exclude:
     - 'lib/fhir_models/bootstrap/model.rb'
 
-# Offense count: 9
+# Offense count: 4
 Style/MultipleComparison:
   Exclude:
     - 'lib/fhir_models/bootstrap/definitions.rb'
     - 'lib/fhir_models/bootstrap/generator.rb'
-    - 'lib/fhir_models/bootstrap/model.rb'
-    - 'lib/fhir_models/fhir_ext/structure_definition.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -185,7 +248,7 @@ Style/OrAssignment:
   Exclude:
     - 'lib/fhir_models/bootstrap/generator.rb'
 
-# Offense count: 16
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, explicit
@@ -194,23 +257,20 @@ Style/RescueStandardError:
     - 'lib/fhir_models/bootstrap/definitions.rb'
     - 'lib/fhir_models/bootstrap/hashable.rb'
     - 'lib/fhir_models/bootstrap/json.rb'
-    - 'lib/fhir_models/bootstrap/model.rb'
     - 'lib/fhir_models/bootstrap/xml.rb'
     - 'lib/fhir_models/fhir.rb'
-    - 'lib/fhir_models/fhir_ext/structure_definition.rb'
     - 'lib/fhir_models/fhir_ext/structure_definition_finding.rb'
     - 'lib/fhir_models/fluentpath/expression.rb'
     - 'lib/fhir_models/fluentpath/parse.rb'
 
-# Offense count: 6
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
 # Whitelist: present?, blank?, presence, try, try!
 Style/SafeNavigation:
   Exclude:
     - 'lib/fhir_models/bootstrap/definitions.rb'
     - 'lib/fhir_models/bootstrap/xml.rb'
-    - 'lib/fhir_models/fhir_ext/structure_definition.rb'
 
 # Offense count: 7
 # Cop supports --auto-correct.

.simplecov

@@ -1,8 +1,12 @@
 require 'simplecov'
-SimpleCov.command_name 'Unit Tests'
+SimpleCov.command_name 'All Tests'
 SimpleCov.start do
-  add_filter "test/"
-  add_group "Library", "lib"
+  add_filter 'test/'
+  add_filter '/spec/'
+  add_group 'Library', 'lib'
+  add_group 'Validation', 'lib/fhir_models/validation'
+  add_group 'FHIR Models', 'lib/fhir_models/fhir/resources'
+  add_group 'Generator Files', 'lib/fhir_models/bootstrap'
 end
 
 class SimpleCov::Formatter::QualityFormatter

Gemfile.lock

@@ -13,15 +13,15 @@ GEM
     ast (2.4.0)
     bcp47 (0.3.3)
       i18n
-    codeclimate-test-reporter (1.0.7)
-      simplecov
+    codeclimate-test-reporter (1.0.9)
+      simplecov (<= 0.13)
     coderay (1.1.2)
     concurrent-ruby (1.1.5)
     coolline (0.5.0)
       unicode_utils (~> 1.4)
     date_time_precision (0.8.1)
     diff-lcs (1.3)
-    docile (1.3.1)
+    docile (1.1.5)
     ffi (1.10.0)
     formatador (0.2.5)
     guard (2.15.0)
@@ -100,11 +100,13 @@ GEM
       rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.6)
+    rubocop-rspec (1.35.0)
+      rubocop (>= 0.60.0)
     ruby-progressbar (1.10.0)
     ruby_dep (1.5.0)
     shellany (0.0.1)
-    simplecov (0.16.1)
-      docile (~> 1.1)
+    simplecov (0.13.0)
+      docile (~> 1.1.0)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
@@ -130,6 +132,7 @@ DEPENDENCIES
   rake
   rspec
   rubocop (= 0.67)
+  rubocop-rspec
   simplecov
   test-unit