Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64-bit port #521

Open
wants to merge 68 commits into
base: port
Choose a base branch
from
Open

64-bit port #521

wants to merge 68 commits into from

Conversation

rafccq
Copy link

@rafccq rafccq commented Oct 14, 2024

Summary of changes:

  • Assets conversion to 64-bit: all pointers inside assets structures changed to 8-byte, and all offsets updated accordingly
  • GDL commands are now 128-bit wide instead of 64. All GDLs inside assets are converted
  • Memory allocations: adjusted allocation sizes in locations where it's hardcoded and some systems heap sizes
  • Every location that stored/cast a pointer using s32/u32 changed to intptr_t/uintptr_t
  • Manually added pad to some structures that contain pointers (casting/alignment requirements)

Raf added 30 commits January 27, 2024 18:25
# Conflicts:
#	Makefile.port
- adjusted hardcoded mask/hardcoded offsets used in memory operations (modelasm_c.c)
- makefile: enabled x64 support and added lib dependency
- title: increase alloc size
- tex: adjustment to calculations involving GDL sizes
jesus didn't help in this off-by-one error hell
… copied

- moved ptrmarkers out of ext_file_bg to common
- function to get ailist length
it works but is still a bit messy, may rewrite it later
Raf and others added 24 commits August 9, 2024 02:31
portx64: fixed pal

Update c-cpp.yml

portx64: fixed linux build

portx64: fixed linux build

ops

portx64: fixed linux build, one more time

portx64: fixed linux build, one more time
added missing dll: libgcc_s_seh-1.dll
# Conflicts:
#	.github/workflows/c-cpp.yml
@FrostKnight
Copy link

Are these the commits to make 64 bit only possible?

@rafccq
Copy link
Author

rafccq commented Oct 18, 2024

32-bit is still supported. In fact, the release will include both 32 and 64-bit builds.

@FrostKnight
Copy link

32-bit is still supported. In fact, the release will include both 32 and 64-bit builds.

Oh no I meant, do you still need 32 bit libraries to build for the 64 bit version.

@rafccq
Copy link
Author

rafccq commented Oct 20, 2024

no, you just need the 64-bit versions of the same libraries used in the 32-bit build.

@FrostKnight
Copy link

no, you just need the 64-bit versions of the same libraries used in the 32-bit build.

Including the multilib ones? If so that is my point. I was wondering when those would no longer be needed

@rafccq
Copy link
Author

rafccq commented Oct 21, 2024

To be honest, I haven't checked if those can be removed, I just added the 64-bit libraries to the x64 build. I can check that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants