Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed viewport calculations for models in menus, and other menu fixes #487

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

MaikelChan
Copy link

  • The size and position of the viewport in every menu was calculated wrongly. This usually didn't cause issues due to most menus being centered on the screen. But viewport would not fit the size of the menu window depending on the game's resolution. This was noticeable in the character selection in multiplayer menus, as those are not centered.
  • Fixed small N64 bug: the red arrows in the character and simulant selection menus were a bit cropped due to the scissor. Now they are a bit more inside the menu window.
  • Fixed wrong position of the model in the device training menu, that would offset base on the game's resolution. Also, the position is recalculated every tick so it doesn't break when resizing the game's window while that training menu is open.
  • Position is now recalculated every tick too in the character profiles menu.

This fixes this issue, maybe others: #427

PD0
PD1

@fgsfdsfgs
Copy link
Owner

Thanks, I've only ever tried to fix the menu model thing for the character bio menu.

@fgsfdsfgs fgsfdsfgs merged commit ca76416 into fgsfdsfgs:port Aug 6, 2024
3 checks passed
@MaikelChan MaikelChan deleted the mp-viewports branch August 6, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants