experimental 4player Counter / Co-Operative #389

NeonNyan · 2024-02-11T01:56:03Z

4 player pvp missions

known issues

coop + anti is still janky
dark rooms + NVG or x-ray vision may be a flashing light hazard

goals

Want to play 4player coop / anti with a mix of coop / anti team characters

No recompiling of ailists. Should "just work" with vanilla levels and well-formed mods.

Load mp profile for coop / anti characters for controller / hud settings / "leveling"

non-goals

Custom characters as coop characters (for now)
Fixing non-breaking n64 bugs beyond what is required
adding coop / anti support for levels not built for it
adding anti support to mp ailists commands that don't use it in retail until modders who actually make levels also weigh in on how they should work

background

In Vanilla PD, 'coopness' or 'antiness' of a PD session is controlled by setting g_Vars.coopplayernum and g_Vars.antiplayernum This is used to determine if coop or anti is running, and what player index to use. Also, coop / anti logic is mutually exclusive.

approach

Porting PD to 4 player local coop/anti requires is set via g_MissionConfig.isteam that allows players to join a solo mission as a team of coop or anti characters.

g_MissionConfig.isteam is set to true when the mission is a team mission.
g_Vars.playerroles is used to track player role constants against player slots. This is used by playermgrAllocatePlayersFromRoles to initialize the player slots and various control variables.

g_Vars.currentplayer is the current player struct.
g_Vars.players : player structs for all players.
g_Vars.currentplayernum is the current player number

g_Vars.coopplayers : player structs for coop players. The bond slot is set to 0 as well as the anti players.
g_Vars.currentcoopnum is the current coop player number. On each frame the coop player is set to the next coop player struct that exists.
g_Vars.coop: current coop player struct

g_Vars.currentantinum is the current anti player number. On each frame the anti player is set to the next anti player struct that exists
g_Vars.antiplayers : player structs for anti players. The anti index is set to 0 as well as the coop players.
g_Vars.anti: current anti player struct

In order to gaurentee that ailist commands that are intending to reference CHR_ANTI, CHR_COOP, and CHR_P1P2/CHR_P1P2OAIlist commands referencing CHR_COOP or CHR_P1P2 will be treated as any or all coop / ally chaaracters.

limitations

scripts targeting CHR_COOP or CHR_P1P2 will need to be treated as any or all ally characters.
This means that mission-related hud messages intended for one coop character will be sent to them all.

acknowledgements

borrowed fixes from @iamgreaser's 4player anti effort: merging the tiktok mode hud settings into 4p, correctly spawning 4 players into a mission
@fgsfdsfgs / Ryan Dwyer for the pc port / decomp but specifically reviewing the scheduling logic and talking me down from attempting any kind of live ailist reinterpretation.

iamgreaser · 2024-02-11T03:34:17Z

I'm having a look at the ailists for a hopefully cleaner solution and it's starting to look a lot more feasible than I thought it would.

Having said that, having a list of all anti and coop players is a nice idea. Not sure how tempted I am to borrow that idea, but I do intend to have something working to the point where you'd have co-op and counter-op stuff happening in the same game mode.

Something you'll want to consider is the CHR_P1P2 reference and the chr_toggle_p1p2(CHR_SELF) command. If you cycle through all protagonist players then I suspect that would tackle the most general cases. But there will definitely be plenty of pain especially pertaining to objectives being failed in situations where they should not be, and also stuff appearing and disappearing while visible to some of the extra co-op players.

NeonNyan · 2024-02-11T06:32:44Z

Cycling the "current coop" player and basing the p1p2 toggle calculation based on MAX_PLAYERS and the current coop number number does make most things work. Like @fgsfdsfgs suggested CHR_COOP / CHR_P1P2_OPPOSITE references in the if_chr_.*(chr,[... ,] label) should check for all the other coop characters (when p1p2_opposite isn't bond) so the ailist can make the appropriate jump. Right now non-bond characters need to tap the use button repeatedly for some ailist scripted objects like lifts and objective items because of the coop cycling. Also the surveillance cameras take a long time to notice non-bond players.

This allows all 4 players to be detected and targeted by enemy guards in coop

... but manually typed in see fgsfdsfgs#383

These work fine in the 2x2 split arrangement.

use currentcoopplayernum instead of coopplayernum p1p2_opposite: attempt to resolve a new player by subtractng the coopplayerindex from the max number of human coop buddies

untested with anti

or coop player

...per waifu's suggestion

JacksBestGaming · 2024-07-08T22:43:36Z

I have no clue who came up with 'Build Your Perfect Team", but I love it so much. This is not only extremely cool on a technical level, but on a creative one as well.

Unradelic · 2024-07-13T12:29:02Z

Happened while fiddling with the menu options, going back and forth, then crashed :P

revert: allyplayers was a bad idea

NeonNyan · 2024-08-18T17:20:38Z

Happened while fiddling with the menu options, going back and forth, then crashed :P

Pretty sure I've seen this while trying to get controllers setup.

fixes menu crashes?

NeonNyan · 2024-08-18T19:46:01Z

Happened while fiddling with the menu options, going back and forth, then crashed :P

cf75ba3 should fix it if it's the same issue I encountered.

NeonNyan · 2024-09-01T04:56:03Z

BUG: vanilla allocation flow disabled and this breaks vanilla campaign flows

… as dead

MonsMarineris · 2024-09-30T20:50:32Z

I am unable to build this for some reason :(
I do admit I have no fuggin clue what I'm doing. But still, I was so excited to try this out.

NeonNyan · 2024-10-02T07:31:54Z

src/game/chraicommands.c

- bgunSetSightVisible(GUNSIGHTREASON_NOCONTROL, false);
- bgunSetGunAmmoVisible(GUNAMMOREASON_NOCONTROL, false);
+ if (isChrPropCoop(chr->prop)) {
+ struct playerpool** playerpool = getPlayerPool(CHR_COOP);


wtf I have no idea how this built and worked on Linux. I'll take a look when I'm on my computer next. Unblocks #389 (comment)

NeonNyan · 2024-10-02T07:33:31Z

I am unable to build this for some reason :(

I do admit I have no fuggin clue what I'm doing. But still, I was so excited to try this out.

I broke windows builds with some stupid code that I'm not sure how it built on Linux. I'll take a look when I'm on my computer next.

NeonNyan · 2024-10-08T03:59:07Z

I'm closing this PR and taking it private until it's in a more stable state.

MonsMarineris · 2024-10-08T08:19:43Z

Thanks for having a look at it. I wish I had any sort of knowledge to help. I'm trying to learn.

NeonNyan force-pushed the dev/4pcoop branch from 5b0ba81 to e7be7a6 Compare May 27, 2024 21:52

NeonNyan and others added 27 commits June 17, 2024 12:31

treat g_Vars.coop and g_Vars.anti like g_Vars.currentplayer

624be55

This allows all 4 players to be detected and targeted by enemy guards in coop

patch written by @iamgreaser

723326d

... but manually typed in see fgsfdsfgs#383

Use vertical-split versions of menus in 3+-player main missions

b876dd2

These work fine in the 2x2 split arrangement.

objective check: check all coop players for required objective item

ce1ccd5

p1p2_opposite is treated as currentcoopnum

7288a55

4pcoop changes

9e5ab45

use currentcoopplayernum instead of coopplayernum p1p2_opposite: attempt to resolve a new player by subtractng the coopplayerindex from the max number of human coop buddies

add orgfile tracking 4pcoopanti ailist progress

370b625

if_chr_dead: handle anti/coop

116cf5f

update notes

953c18c

aiChrIfDead respects g_Vars.playerorder

1d765ff

aiIfChrDeathAnimationFinished now supports 4pcoop and 4panti

25f342e

untested with anti

helper function

19c30bf

update coopanti notes

b0ac417

update notes

1e4c70f

cctvtick will enumerate over all players and break if it finds one bond

a1151c9

or coop player

setchrflags

e1c7ad7

aiGiveObjectToChr

812a120

propobj checks if any coop player is using it

6defef9

some helper functions for checking coop / antiness

1d8c359

endscreen: setNumPlayers(4)

eb6baa5

update notes

327dbb9

fixup: 4pcoop: cleanup check

cae7aef

4pcoop: spawn radius fix for multiple human players

76e87ba

4pcoop: remove comment

5ff7b2c

4pcoop: fixup solo / coop picking for head / body determination

7737d98

4pcoop: shorten the length of time in front of cctv before alarm trips

362ff29

more reliable isanti check

6265827

NeonNyan added 5 commits July 5, 2024 17:33

windows build issues

c4db99e

fixup playerroles

7657014

windows build issue

bf00fc1

windows build issue

0f17391

windows build issue

8f20166

NeonNyan force-pushed the dev/4pcoop branch from db0a202 to 8f20166 Compare July 6, 2024 01:09

NeonNyan added 2 commits July 6, 2024 12:19

Renamed "Team Missions" -> Quad-Operative

7d0d0f4

...per waifu's suggestion

fix p1p2 scheduling issues

c86184a

NeonNyan changed the title ~~experimental 4player coop~~ experimental 4player Counter / Co-Operative Jul 7, 2024

really fix p1p2 scheduling issues

3202ead

revert: allyplayers was a bad idea

NeonNyan added 3 commits August 18, 2024 12:28

fix player allocation

66101b3

use PLAYERCOUNT() instead of MAX_PLAYERS

97f47bd

don't set g_Vars.mplayerisrunning = true in menus

cf75ba3

fixes menu crashes?

NeonNyan added 5 commits September 1, 2024 13:10

fixup: aiIfChrDeathAnimationFinished no longer incorrectly marks coop…

044a29d

… as dead

fixup: use seperate continue button handlers for team / coop modes

1548ebf

coop support for aiRevokeControl

dcc6475

teleportals kind of work

2fa0b2f

fixup: this will help us move around the ship quicker

b030f0c

NeonNyan commented Oct 2, 2024

View reviewed changes

NeonNyan closed this Oct 8, 2024

NeonNyan deleted the dev/4pcoop branch October 8, 2024 03:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

experimental 4player Counter / Co-Operative #389

experimental 4player Counter / Co-Operative #389

NeonNyan commented Feb 11, 2024 •

edited

Loading

iamgreaser commented Feb 11, 2024

NeonNyan commented Feb 11, 2024

JacksBestGaming commented Jul 8, 2024

Unradelic commented Jul 13, 2024

NeonNyan commented Aug 18, 2024

NeonNyan commented Aug 18, 2024

NeonNyan commented Sep 1, 2024 •

edited

Loading

MonsMarineris commented Sep 30, 2024

NeonNyan Oct 2, 2024

NeonNyan commented Oct 2, 2024

NeonNyan commented Oct 8, 2024

MonsMarineris commented Oct 8, 2024

experimental 4player Counter / Co-Operative #389

experimental 4player Counter / Co-Operative #389

Conversation

NeonNyan commented Feb 11, 2024 • edited Loading

4 player pvp missions

known issues

goals

non-goals

background

approach

limitations

acknowledgements

iamgreaser commented Feb 11, 2024

NeonNyan commented Feb 11, 2024

JacksBestGaming commented Jul 8, 2024

Unradelic commented Jul 13, 2024

NeonNyan commented Aug 18, 2024

NeonNyan commented Aug 18, 2024

NeonNyan commented Sep 1, 2024 • edited Loading

MonsMarineris commented Sep 30, 2024

NeonNyan Oct 2, 2024

Choose a reason for hiding this comment

NeonNyan commented Oct 2, 2024

NeonNyan commented Oct 8, 2024

MonsMarineris commented Oct 8, 2024

NeonNyan commented Feb 11, 2024 •

edited

Loading

NeonNyan commented Sep 1, 2024 •

edited

Loading