Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atomic set and redis pool size #124

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

kozak
Copy link
Contributor

@kozak kozak commented Nov 12, 2024

No description provided.

@fffonion
Copy link
Owner

@kozak Thank you for keep this updated. Could you rebase to latest master? There's some changes to redis driver.

@jborkowski jborkowski force-pushed the use-atomic-set-and-redis-pool-size branch from a8bcc95 to febf816 Compare November 13, 2024 12:18
@kozak
Copy link
Contributor Author

kozak commented Nov 13, 2024

@jborkowski has just done a rebase.

Btw. the atomic set changes have eliminated the locking issue, so it would be nice if they could be merged into master :)

The redis pool size change doesn't seem to be controversial, but does come with a requirement for ngx lua 0.10.14 (https://github.com/openresty/lua-resty-redis?tab=readme-ov-file#connect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants