Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update genesis_time upon genesis export [Experimental] #174

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: update genesis_time upon genesis export [Experimental] #174

wants to merge 3 commits into from

Conversation

Jonathansumner
Copy link
Member

@Jonathansumner Jonathansumner commented Jun 5, 2024 •
edited
Loading

Requires further testing!

  • May play a role in future experimentation with Alexandria. E.g. reading blockdata from a running fetchd node.

@Jonathansumner Jonathansumner self-assigned this Jun 5, 2024
pbukva
pbukva approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@pbukva pbukva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pbukva
pbukva requested changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@pbukva pbukva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to fix the cosmetic complaints CI ia having.

@Jonathansumner Jonathansumner added S-do-not-merge Status: This pull request is NOT ready to be merged C:CLI labels Jun 10, 2024
@Jonathansumner Jonathansumner changed the title feat: update genesis_time upon genesis export feat: update genesis_time upon genesis export [Experimental] Jun 10, 2024
@Jonathansumner Jonathansumner marked this pull request as draft June 10, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbukva pbukva pbukva requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Jonathansumner Jonathansumner

Labels
C:CLI S-do-not-merge Status: This pull request is NOT ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jonathansumner @pbukva