Optimize (not) printing empty string from formatter #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is handy to implement some additional filtering in a custom formatter function. In this case the formatter can return the empty string if it wants to ignore a trace message. Optimize the formatting so in the empty string case it does not send an io request to the IO server. This saves some message passing and avoids a "flickering prompt" effect (when the empty string is printed) in case of 1000s of ignored trace messages per second.
Tested manually in
rebar3 shell
(before this patch prompt4>
used to "flicker"):