Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve EMOJI_CODEPOINT_COMPARATOR #18

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Improve EMOJI_CODEPOINT_COMPARATOR #18

merged 4 commits into from
Nov 14, 2023

Conversation

freya022
Copy link
Contributor

Depends on #17

@freya022 freya022 mentioned this pull request Nov 12, 2023
Merged
@freya022 freya022 force-pushed the refactor/emoji-codepoint-comparator branch from 3df12fd to 3123e1d Compare November 14, 2023 08:20
@freya022 freya022 marked this pull request as ready for review November 14, 2023 08:20
felldo
felldo approved these changes Nov 14, 2023
View reviewed changes
Copy link
Owner

@felldo felldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some changes and an Emoji is now Comparable :)
Thanks for finding out that String#codepointCount is a lot faster 🙂

@felldo felldo merged commit d9df8f9 into felldo:master Nov 14, 2023
1 check passed
@freya022 freya022 deleted the refactor/emoji-codepoint-comparator branch November 16, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felldo felldo felldo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freya022 @felldo