Update workflow and fix endian conversion and alignment in cista::generic_string #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/cista/serialization.h
Outdated
| el->h_.size_ * sizeof(typename generic_string<Ptr>::CharT)); | ||
| } | ||
| str_convert_endian(c, el->data(), static_cast<std::size_t>(el->h_.size_)); | ||
| } catch (...) { |
There was a problem hiding this comment.
why is the exception swallowed here?
There was a problem hiding this comment.
Checks are supposed to be made in check_state function, so I think it's expected convert_endian_and_ptr doesn't throw exceptions related to incorrect data.
Shouldn't it be swallowed?
There was a problem hiding this comment.
The idea of convert_endian_and_ptr is that it doesn't do any checking at all. If you want to do the endian conversion of the data inside the string after the check, then this would be a recursive step iterating the elements in the string.
There was a problem hiding this comment.
Alright. Then I'll rewrite this part
|
LGTM - ready for merge? |
|
Yes. I have nothing to add to this PR |
|
Thank you! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflows
cista::generic_string