[DEV-11086] Add new PYA and PARK fields to Files B and C #4212
Conversation
| prior_year_adjustment = models.TextField(blank=True, null=True) | ||
| pa_reporting_key = models.TextField(blank=True, null=True) |
There was a problem hiding this comment.
Do we expect a certain set of values for these fields (e.g. can we use choices)?
There was a problem hiding this comment.
Choices is a good idea when we're accepting something from a source that hasn't been validated (maybe user submission). In this case, we're reading data from the broker, which has already performed it's own set of validations.
We could still potentially add options here, but if anything changes on the schema side (a new PARK is added, we'd need to make sure to update this before hand, or else the submission loader would fail).
I'd also suspect that in this case, there might be too many options to include here. We have quite a few program activities.
I can add help_text as Seth suggested though.
| @@ -17,6 +17,8 @@ class AbstractFinancialAccountsByAwards(DataSourceTrackedModel): | |||
| parent_award_id = models.TextField(blank=True, null=True) | |||
| fain = models.TextField(blank=True, null=True) | |||
| uri = models.TextField(blank=True, null=True) | |||
| prior_year_adjustment = models.TextField(blank=True, null=True) | |||
| pa_reporting_key = models.TextField(blank=True, null=True) | |||
There was a problem hiding this comment.
Since there was a question about what pa_ stands for it might be good to make use of help_text here similar to this spot on Award model: https://github.com/fedspendingtransparency/usaspending-api/blob/master/usaspending_api/awards/models/award.py#L54
| @@ -13,6 +13,8 @@ class AbstractFinancialAccountsByProgramActivityObjectClass(DataSourceTrackedMod | |||
| treasury_account = models.ForeignKey( | |||
| "accounts.TreasuryAppropriationAccount", models.CASCADE, related_name="program_balances", null=True | |||
| ) | |||
| prior_year_adjustment = models.TextField(blank=True, null=True) | |||
| pa_reporting_key = models.TextField(blank=True, null=True) | |||
There was a problem hiding this comment.
Similar use of help_text here would be nice.
Description:
Broker is introducing 4 new fields to be to both their file b and c tables. We should update our corresponding tables and loaders to ensure these fields are read.
Technical details:
Field and table details can be found in ticket.
This should not be merged until broker adds these fields
Requirements for PR merge:
test_load_multiple_submissionstest to ensure that the build will fail until broker adds these fields. Other than that, we don't have a comprehensive test that ensures that each individual field was successfully loaded from broker during the submission loader.Area for explaining above N/A when needed: