This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Add option for new AAA backend #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit adds the ability to query users from the freeipa backend instead of fas. the freeipa_backend config variable will be added to the ansible repo and turned to False by default. Signed-off-by: Stephen Coady <[email protected]>
Signed-off-by: Stephen Coady <[email protected]>
abompard
suggested changes
May 25, 2020
pdcupdater/services.py
Outdated
| log.info("Connecting to Account System at %r" % base_url) | ||
| if freeipa_backend: | ||
| client = Client(url=base_url) | ||
| response = client.users.list_users().response().result |
There was a problem hiding this comment.
That's the old API, it should now be client.list_users()
Signed-off-by: Stephen Coady <[email protected]>
Signed-off-by: Stephen Coady <[email protected]>
abompard
reviewed
May 27, 2020
| @@ -21,7 +21,7 @@ $script = <<SCRIPT | |||
| SCRIPT | |||
|
|
|||
| Vagrant.configure("2") do |config| | |||
| config.vm.box = "fedora/24-cloud-base" | |||
abompard
suggested changes
May 27, 2020
pdcupdater/services.py
Outdated
| if fasjson: | ||
| client = Client(url=base_url) | ||
| response = client.list_users().result | ||
| people = response.get('result', []) |
There was a problem hiding this comment.
Hmm no you don't need that I think. The data is directly available in the .result property.
Signed-off-by: Stephen Coady <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds the ability to query users from the freeipa
backend instead of fas. the freeipa_backend config variable
will be added to the ansible repo and turned to False by default.
Signed-off-by: Stephen Coady [email protected]