Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run logdetective server in a container #51

Merged
merged 4 commits into from
Aug 13, 2024

Commits on Aug 9, 2024

  1. Run logdetective server in a container

    Signed-off-by: Tomas Tomecek <[email protected]>
    TomasTomecek committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    14fa4df View commit details
    Browse the repository at this point in the history
  2. compose: utilize .env

    so we can store ports, hosts, paths in one place and just reference it
    
    also simplifies the Containerfile
    
    there are no models being downloaded anymore, you need to supply them
    using $MODELS_PATH - this directory is bindmounted inside the llama-cpp
    container
    
    Signed-off-by: Tomas Tomecek <[email protected]>
    Co-authored-by: Jiri Podivin <[email protected]>
    Co-authored-by: Jiri Konecny <[email protected]>
    3 people committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f46d125 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. do multiple containerization improvements

    1. align port numbers b/w code, composefile and .env
    2. require PORT env vars to be nonempty
    3. containerfile→build: specify containerfile path
    4. fixup interpolation within .env
    
    address review comments from @jpodivin
    
    Signed-off-by: Tomas Tomecek <[email protected]>
    TomasTomecek committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    4eb5c1e View commit details
    Browse the repository at this point in the history
  2. compose: drop LLM_CPP_SERVER_ADDRESS

    so we don't interpolate inside .env which doesn't work correctly on all
    compose implmentations:
    
    ```
    [server]    | requests.exceptions.ConnectionError:
    HTTPConnectionPool(host='$%7bllama_cpp_host%7d', port=8000): Max retries
    exceeded with url: /v1/completions (Caused by
    NewConnectionError('<urllib3.connection.HTTPConnection object at
    0x7ff685f4bad0>: Failed to establish a new connection: [Errno -2] Name
    or service not known'))
    ```
    TomasTomecek committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3b9e186 View commit details
    Browse the repository at this point in the history