Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update radio-button selected-state #141

Merged
merged 1 commit into from
Jul 19, 2019
Merged

Conversation

johnnyporkchops
Copy link
Contributor

@johnnyporkchops johnnyporkchops commented Jul 16, 2019

Summary of changes

update radio button selected-state. This was changed in fec-cms PR #3014, Issue #2950

Update node_modules to get the new radio button styles
Edit Read.Me for radio button
Update package.json and package-lock.json

How to Test:

  • Checkout branch
  • npm install
  • npm run build
  • npm run start
  • Check Components > Filters > Radio Buttons to confirm that the slected state now looks like this:
    Screen Shot 2019-07-16 at 1 32 37 PM

Copy link
Member

@patphongs patphongs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @johnnyporkchops, thanks for updating the radio button styling

Copy link
Contributor

@JonellaCulmer JonellaCulmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks so much, @johnnyporkchops!

@JonellaCulmer JonellaCulmer merged commit 9b0c134 into master Jul 19, 2019
@lbeaufort lbeaufort deleted the update-radio-buttons branch June 2, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants