Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
Resolves Tech-debt: Remove reporting-dates-tables.js by converting legacy tables to use new template and JS #6491
Remove the legacy
eporting-dates-tables.js
Rename the new
election-reporting-dates-tables.js
toreporting-dates-tables.js
so template and JS files have the same name for clarityRemove references to JS in
full_width_page.html
Required reviewers
one frontend and optionally one content (@djgarr)
Impacted areas of the application
Reporting dates tables from 2020 to present
deleted: fec/static/js/pages/election-reporting-dates-tables.js
modified: fec/static/js/pages/reporting-dates-tables.js
modified: home/templates/home/full_width_page.html
modified: home/templates/home/reporting_dates_table.html
Related issues/PRs
Issues:
#5153
PRs:
New:
#5786
#5798
Legacy:
#3227
How to test
npm run build-js
reporting_dates_table.html
for JS functionality (footnotes, state dropdown, header notes)