Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move state and territory filter #6490

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

patphongs
Copy link
Member

@patphongs patphongs commented Sep 25, 2024

Summary (required)

Per ticket specifications, re-arrange filters and update text accordingly.

Required reviewers

1 UX
1 front end developer

Impacted areas of the application

General components of the application that this PR will affect:

  • Individual contributions datatable filters
  • Receipt datatable filters

Screenshots

Receipts datatable

Screenshot 2024-09-25 at 5 15 24 PM Screenshot 2024-09-25 at 5 15 03 PM Screenshot 2024-09-25 at 5 14 33 PM Screenshot 2024-09-25 at 5 14 06 PM

Individual contributions datatable

Screenshot 2024-09-25 at 5 24 10 PM Screenshot 2024-09-25 at 5 23 55 PM Screenshot 2024-09-25 at 5 23 32 PM Screenshot 2024-09-25 at 5 41 49 PM

How to test

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.48%. Comparing base (738f129) to head (5a7c86a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6490   +/-   ##
========================================
  Coverage    80.48%   80.48%           
========================================
  Files          234      234           
  Lines         5093     5093           
========================================
  Hits          4099     4099           
  Misses         994      994           
Flag Coverage Δ
80.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonellaCulmer
Copy link
Contributor

@patphongs, I'm hoping we can handle each of the updated sections the same way. Here are (mostly) screenshots of the Time period accordion but the changes affect multiple sections. I'd like to change the margin-top (5) and padding-top (10) in two areas, as well as the line height in the paragraphs (1.5). This removes some of the extra space above the new paragraphs and tightens up the text a bit. There's also a type: accross. Please let me know if I should present this all differently to you.

Accordion padding top (10)

Screenshot 2024-10-01 at 5 24 52 PM

Label margin top (5)

Screenshot 2024-10-01 at 5 12 43 PM

Small typo

Screenshot 2024-10-01 at 5 13 01 PM

Line height (1.5)

Screenshot 2024-10-01 at 5 13 31 PM
Screenshot 2024-10-01 at 5 27 43 PM
Screenshot 2024-10-01 at 5 27 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Move state or territory filter and other adjustments on receipts and individual contributions datatables
2 participants