fix: Bigquery dataset create table disposition #4649
+17
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gration tests, added self param to a method that was failing linting and ignoring other issues Signed-off-by: Dan Baron <[email protected]>
…n get_historical_features is called Signed-off-by: Dan Baron <[email protected]>
…o kwargs in the repo_configuration integration tests Signed-off-by: Dan Baron <[email protected]>
…o fix due to length of type required and imports Signed-off-by: Dan Baron <[email protected]>
Signed-off-by: Dan Baron <[email protected]>
Signed-off-by: Dan Baron <[email protected]>
danbaron63
changed the title
danbaron63
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
get_historical_featuresto not create a BigQuery dataset whencreate_table_dispositionis set toCREATE_NEVER.Which issue(s) this PR fixes:
Fixes #4648
Misc
This PR brings BigQuery dataset creation in line with table creation - this will hopefully be useful to orgs (such as mine!) that have stricter requirements over what can/cannot make infrastructure/warehouse changes in production environments. In our case
get_historical_featuresis expected to be read only operation.