Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Couchbase as an online store #4637

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ejscribner
Copy link

@ejscribner ejscribner commented Oct 17, 2024

What this PR does / why we need it:

Adds the ability to use Couchbase as an online store.

Which issue(s) this PR fixes:

N/A

Misc

While the docs focus on using this Online Store with Couchbase Capella Operational (Couchbase's cloud offering), the tests have all been set up to run with Couchbase Server. The subsequent Offline Store that will follow will require Couchbase Capella, hence the emphasis in the docs.

@ejscribner ejscribner marked this pull request as ready for review October 17, 2024 00:13
@franciscojavierarceo
Copy link
Member

Hey @ejscribner can you fix the DCO verification? You can do it in the UI.

@ejscribner
Copy link
Author

Hey @franciscojavierarceo thanks for pointing this out, updated the commits with signoff.

Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
Signed-off-by: Elliot Scribner <[email protected]>
@ejscribner
Copy link
Author

Fixed conflicts in dependency lockfiles. Also, I noticed that this PR bumps some of the deps, likely happened when I did make lock-python-dependencies-all. Is this ok, or should we revert those versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants