Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hint position test, README entry about ligatures #161

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add hint position test, README entry about ligatures #161

wants to merge 6 commits into from

Conversation

purajit
Copy link

@purajit purajit commented Sep 13, 2024 •
edited
Loading

I had an issue with hint positions being incorrect, and noticed it only happened in certain places.

$ echo "a0240913-ligatures-test"
s0240913-ligatures-test
$ echo "-d0240913-ligatures-test"
-f0240913-ligatures-test
$ echo "↳20q0240913-ligatures-test
↳20w0240913-ligatures-test

It's all about ligatures!

Add a test since none of the existing tests check for hint positioning. Added a troubleshooting
entry in the README as well.

As for actually solving this issue, we would need something like #162

@purajit purajit marked this pull request as draft September 13, 2024 22:51
@purajit purajit mentioned this pull request Sep 13, 2024
Open
@purajit purajit changed the title test effect of ligatures on hint positioning Add hint position test, README entry about ligatures Sep 13, 2024
@purajit purajit mentioned this pull request Sep 14, 2024
Open
@purajit purajit marked this pull request as ready for review September 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@purajit