Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick for with items range #172

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

erkannt
Copy link

@erkannt erkannt commented Mar 6, 2023

Closes: #171

Should I update the examples in the readme or the syntax file?

I originally stumbled across this by following those and expecting it to just work.

@fcsonline
Copy link
Owner

Yep, add some examples to be able to understand this capability.

@erkannt
Copy link
Author

erkannt commented Mar 21, 2023

Updated docs.

Do I need to address the clippy failure? Looks like it is failing due to running against a fork. When I run it locally the error does not reproduce.

@erkannt
Copy link
Author

erkannt commented Aug 21, 2023

Please let me know if there is anything I can do to move along this PR. Hoping to reduce my PR WIP ^^

@fcsonline fcsonline merged commit da4bd88 into fcsonline:master Aug 21, 2023
8 checks passed
@fcsonline
Copy link
Owner

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pick doesn't work for with_items_range
2 participants