Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample without replacement for shuffle #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arun-rangarajan
Copy link

np.random.randint(min_index + lookback, max_index, size=batch_size)
does sampling with replacement, so it allows duplicates.

Use
np.random.choice(range(min_index + lookback, max_index), size=batch_size, replace=False)
for doing shuffle.

`numpy.random.randint` does sampling with replacement. Change to `numpy.random.choice` and set `replace=False` for sampling without replacement.
Pull req on IPython NB!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant