Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Q_Object from ServiceProcess #47994

Closed
wants to merge 1 commit into from
Closed

Remove Q_Object from ServiceProcess #47994

wants to merge 1 commit into from

Conversation

sima-fastly
Copy link
Contributor

Remove Q_Object from ServiceProcess

@sima-fastly sima-fastly self-assigned this May 17, 2024
jkarneges
jkarneges reviewed May 20, 2024
View reviewed changes
Copy link
Member

@jkarneges jkarneges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't remove the macro without also removing the inheritance, but here QProcess is not easily removed. Let's skip for now, and in the meantime maybe the new runner will take over and we won't have to worry about it.

@sima-fastly sima-fastly deleted the sima/qobj/serviceprocess branch June 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkarneges jkarneges jkarneges left review comments

Assignees

@sima-fastly sima-fastly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sima-fastly @jkarneges