Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mechanism of saving waypoints #51

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Improve mechanism of saving waypoints #51

merged 1 commit into from
Jul 27, 2023

Conversation

KavitShah1998
Copy link
Contributor

No description provided.

@KavitShah1998 KavitShah1998 self-assigned this Jul 17, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2023
@KavitShah1998 KavitShah1998 marked this pull request as draft July 17, 2023 22:06
@KavitShah1998 KavitShah1998 changed the title Improve mechanism of saving waypoints [DRAFT] - Improve mechanism of saving waypoints Jul 17, 2023
@KavitShah1998 KavitShah1998 force-pushed the improve_saving_waypoints_mechanism branch 3 times, most recently from 7d4dd03 to 5d6e65c Compare July 20, 2023 00:10
@KavitShah1998 KavitShah1998 marked this pull request as ready for review July 20, 2023 00:10
@KavitShah1998 KavitShah1998 changed the title [DRAFT] - Improve mechanism of saving waypoints Improve mechanism of saving waypoints Jul 20, 2023
@KavitShah1998 KavitShah1998 mentioned this pull request Jul 20, 2023
Closed
jimmytyyang
jimmytyyang reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! thanks!

spot_rl_experiments/configs/waypoints_apartment.yaml Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/waypoint_recorder.py Show resolved Hide resolved
@KavitShah1998 KavitShah1998 force-pushed the improve_saving_waypoints_mechanism branch 2 times, most recently from 5de48d4 to 6a8208a Compare July 26, 2023 02:37
jimmytyyang
jimmytyyang approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@jimmytyyang jimmytyyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

akshararai
akshararai approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@akshararai akshararai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, but looks good otherwise

spot_rl_experiments/configs/waypoints_apartment.yaml Outdated Show resolved Hide resolved
spot_rl_experiments/configs/waypoints_microkitchen.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
spot_rl_experiments/configs/waypoints_apartment.yaml Outdated Show resolved Hide resolved
spot_rl_experiments/configs/waypoints_microkitchen.yaml Outdated Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/waypoint_recorder.py Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/waypoint_recorder.py Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/waypoint_recorder.py Show resolved Hide resolved
spot_rl_experiments/spot_rl/utils/waypoint_recorder.py Show resolved Hide resolved
@KavitShah1998 KavitShah1998 force-pushed the improve_saving_waypoints_mechanism branch from 6a8208a to 5691caa Compare July 27, 2023 03:50
akshararai
akshararai approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@akshararai akshararai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks so nice, thank you!

@KavitShah1998 KavitShah1998 force-pushed the improve_saving_waypoints_mechanism branch from 75922a7 to 3e85868 Compare July 27, 2023 20:37
@KavitShah1998
Copy link
Contributor Author

Merging the PR as it is approved by all.

Thank you @jimmytyyang @akshararai 🚀 🤖

@KavitShah1998 KavitShah1998 merged commit 6c3bb30 into main Jul 27, 2023
1 check passed
@KavitShah1998 KavitShah1998 deleted the improve_saving_waypoints_mechanism branch July 27, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshararai akshararai akshararai approved these changes

@jimmytyyang jimmytyyang jimmytyyang approved these changes

Assignees

@KavitShah1998 KavitShah1998

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KavitShah1998 @akshararai @jimmytyyang @facebook-github-bot