Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GPU CI #207

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Refactor GPU CI #207

merged 1 commit into from
Sep 4, 2024

Conversation

mthrok
Copy link
Collaborator

@mthrok mthrok commented Sep 3, 2024 •
edited
Loading

  • Add GPU testing
    • This fails due to 4-core-ubuntu-gpu-t4 not having libnvcuvid.so.
    • TODO: Try running docker with NVIDIA_DRIVER_CAPABILITIES=all.
  • Fix conda packaging
    • environment variables are not passed
  • Convert gpu workflows to reusable ones.

TODO:

  • Add mac Wheel
  • Fix GPU unit test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 3, 2024
@mthrok mthrok force-pushed the gpu-ci branch 19 times, most recently from de63c5a to 1aaf9b4 Compare September 3, 2024 20:28
@mthrok mthrok changed the title Add GPU test Refactor GPU CI Sep 3, 2024
@mthrok mthrok force-pushed the gpu-ci branch 9 times, most recently from 87b8759 to 1c07f5a Compare September 3, 2024 23:13
@mthrok mthrok force-pushed the gpu-ci branch 17 times, most recently from 68775a3 to 680924c Compare September 4, 2024 05:34
@mthrok mthrok force-pushed the gpu-ci branch 2 times, most recently from 933ea6a to ec825a6 Compare September 4, 2024 06:37
@mthrok mthrok marked this pull request as ready for review September 4, 2024 06:39
@mthrok mthrok merged commit 0d1a6d0 into main Sep 4, 2024
15 of 20 checks passed
@mthrok mthrok deleted the gpu-ci branch September 4, 2024 06:39
@mthrok mthrok mentioned this pull request Sep 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mthrok @facebook-github-bot