Add warning about pin_memory option

facebookresearch · Oct 4, 2024 · c9cf14d · c9cf14d
1 parent b74e902
commit c9cf14d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/libspdl/core/conversion.h b/src/libspdl/core/conversion.h
@@ -15,6 +15,8 @@
 
 namespace spdl::core {
 
+// The actual implementation is found in
+// detail/ffmpeg/conversion.cpp
 template <MediaType media_type>
 CPUBufferPtr convert_frames(
     const std::vector<const FFmpegFrames<media_type>*>& batch,

diff --git a/src/libspdl/core/storage/cpu.cpp b/src/libspdl/core/storage/cpu.cpp
@@ -33,6 +33,8 @@ CPUStorage::CPUStorage(size_t size, bool pin_memory) {
     LOG(WARNING)
         << "`pin_memory` requires SPDL with CUDA support. Falling back to CPU memory.";
 #else
+    LOG(WARNING)
+        << "`pin_memory` is under development and is currently known to be slower and unstable";
     CHECK_CUDA(
         cudaHostAlloc(&data_, size, cudaHostAllocDefault),
         "Failed to allocate pinned memory.");