Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: There is no guarantee that the function pointer `imageFeaturePointDetectorFunction_` returns `false` when no features have been detected. For an example, see https://www.internalfb.com/code/fbsource/[970f113ed98c]/xplat/ocean/impl/metaonly/application/ocean/xrplayground/common/experiences/mrroomplan/MRRoomPlanPhoneExperience.cpp?lines=525 The function [`Tracking::MapBuilding::Relocalizer::detectFreakFeatures()`](https://www.internalfb.com/code/fbsource/[970f113ed98c926ea0e815d8763172e587154465]/xplat/ocean/impl/ocean/tracking/mapbuilding/Relocalizer.cpp?lines=52%2C96) will return `true` even when no features have been detected. This can trigger [`asserts`](https://www.internalfb.com/code/fbsource/[970f113ed98c]/xplat/ocean/impl/ocean/tracking/mapbuilding/RelocalizerStereo.cpp?lines=71-72). This change add an explicit check if features were found. Reviewed By: janherling Differential Revision: D64793617 Privacy Context Container: L1191897 fbshipit-source-id: 155638f761fb8b832be2bb9c846a34c758abef70
- Loading branch information