Skip to content

Commit

Permalink
Update geometry.md (#10)
Browse files Browse the repository at this point in the history
Summary:
Correct axis for camera flip rotation.

**Pull Request Template**

**Summary**
I think the docs mis-identify which axis is rotated around to convert between standard and flipped camera.

* Briefly describe the changes made in this pull request:
  + [Insert summary of changes]

**Changes**

* Describe the changes made in this pull request:
  + [Insert detailed description of changes]
  + Include relevant information about:
    - New features added
    - Bugs fixed
    - Performance improvements
    - Code refactoring

**Motivation**

* Explain the motivation behind making these changes:
  + [Insert motivation behind changes]

**Testing**

* Describe the testing performed to verify the changes:
  + [Insert testing details]
  + Include information about:
    - Test cases added or modified
    - Results of testing

**Checklist**

* Confirm that the following have been completed:
  + [ ] Code compiles and runs successfully on all supported platforms
  + [ ] All tests pass
  + [ ] Documentation is updated (if applicable)
  + [ ] Changes follow the project's coding standards

**Additional Comments**

* Any additional comments or information that may be helpful:
  + [Insert additional comments]

Pull Request resolved: #10

Reviewed By: janherling

Differential Revision: D59539402

Pulled By: enpe

fbshipit-source-id: b491eb4d7cec804ce07372cd33bb391221a553e3
  • Loading branch information
stuart-fb authored and facebook-github-bot committed Jul 9, 2024
1 parent 7a34c2c commit 56e00bb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion website/docs/geometry/geometry.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ In contrast to the CG coordinate system, Computer Vision applications often use
- The **z-axis** points away from the observer (the camera points towards the positive z-space)

To accommodate this variation, Ocean introduces the "flipped camera" coordinate system.
Converting from the standard camera to the flipped camera involves a 180-degree rotation around the z-axis. Below is an illustration for clarity:
Converting from the standard camera to the flipped camera involves a 180-degree rotation around the x-axis. Below is an illustration for clarity:

<img src={require('@site/static/img/docs/geometry/ocean_coordinatesystem_flippedcamera.jpg').default} alt="Image: Ocean's flipped camera coordinate system" height="600" className="center-image"/>

Expand Down

0 comments on commit 56e00bb

Please sign in to comment.