upgrade fbpcs to per-target typechecking #2414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
force-pushed
the
export-D64347224
branch
from
d4477ef
to
5529356
Compare
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64347224 |
Summary:
We're migrating fbcode to use Pyre's new architecture.
To type check your project:
```
arc pyre check //fbpcs/...
```
You can enable this by adding `typing = True` to individual buck targets OR
```
# in a PACKAGE file
load("fbcode_macros//build_defs:python.bzl", "python")
python.set_typing(True)
```
will type check all buck targets nested underneath.
This diff removes the configuration and replaces it with our new buck based architecture and silences any resulting errors.
The test failure is preexisting.
Reviewed By: joe1234wu
Differential Revision: D64347224
joe1234wu
force-pushed
the
export-D64347224
branch
from
5529356
to
d6a5c4b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64347224 |
|
@dluo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're migrating fbcode to use Pyre's new architecture.
To type check your project:
You can enable this by adding
typing = Trueto individual buck targets ORwill type check all buck targets nested underneath.
This diff removes the configuration and replaces it with our new buck based architecture and silences any resulting errors.
The test failure is preexisting.
Reviewed By: joe1234wu
Differential Revision: D64347224