Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramatized rust_static_library to enable CXX support #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jdelliot
Copy link
Contributor

Summary:
X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, USE_CXX_INCLUDE, to the CMake function, rust_static_library, to enable adding the cxxbridge path to the include path.

Differential Revision: D50772544

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 29, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50772544

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50772544

Summary:
X-link: facebookincubator/delos_core#8

X-link: facebookincubator/zstrong#610

X-link: facebookincubator/crux#10

X-link: facebookexternal/traffixr#3

X-link: facebookincubator/katran#205

X-link: facebookincubator/fizz#101

X-link: facebook/sapling#763

X-link: facebookexperimental/rust-shed#43

X-link: facebook/wangle#221

X-link: facebook/openr#150

X-link: facebook/hhvm#9403

X-link: facebook/folly#2092

X-link: facebook/fb303#42

X-link: facebookincubator/velox#7301

We are now using CXX (and not just bindgen/cbindgen) for building our Rust C/C++ APIS, but our OSS tooling did not ergomically support this. This change adds a single option, `USE_CXX_INCLUDE`, to the CMake function, `rust_static_library`, to enable adding the `cxxbridge` path to the include path.

Reviewed By: xavierd

Differential Revision: D50772544
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50772544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants