Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ddst_dict_init api support for rocksdb dd #1297

Open
wants to merge 1 commit into
base: fb-mysql-8.0.28
Choose a base branch
from

Conversation

sunshine-Chun
Copy link
Contributor

Summary: Add ddst_dict_init api support for rocksdb dd

Test Plan: Test locally, not crush....

Reviewers:

Subscribers:

Tasks:

Tags:

storage/rocksdb/ha_rocksdb.cc Outdated Show resolved Hide resolved
storage/rocksdb/ha_rocksdb.cc Outdated Show resolved Hide resolved
storage/rocksdb/ha_rocksdb.cc Show resolved Hide resolved
storage/rocksdb/rdb_global.h Outdated Show resolved Hide resolved
storage/rocksdb/ha_rocksdb.cc Outdated Show resolved Hide resolved

static Plugin_tablespace dd_space(rocksdb_dd_space_name, "", "", "",
rocksdb_hton_name);
tablespaces->push_back(&dd_space);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, tablespaces are purely InnoDB concept. So nothing should be added here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DD expect mysql namespace always exists.. Let me find related code in a while..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current DD layer assumes it does, but I am patching it out in my prototype.
I am concerned about pretending something exists when MyRocks does not even support the concept of it.

@sunshine-Chun sunshine-Chun force-pushed the fb-mysql-8.0.28-dd-api2 branch 2 times, most recently from 88b36f4 to 7897e70 Compare April 28, 2023 23:12

namespace dd {
class Table;
}

namespace myrocks {

constexpr const char *rocksdb_dd_space_name = "mysql";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
constexpr const char *rocksdb_dd_space_name = "mysql";
constexpr const char rocksdb_dd_space_name[] = "mysql";

The pointer version works, but its sizeof is 8, which is very annoying to find

@sunshine-Chun
Copy link
Contributor Author

Do we still need this diff. Sounds like we are not adding the. dd_space in the ddst_dict_init function now.

@laurynas-biveinis
Copy link
Contributor

As with the rest of the current diffs, it's hard to say, as the code is too incomplete to run. IMHO we can hold until it becomes clear.

@facebook-github-bot
Copy link

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@luqun
Copy link
Contributor

luqun commented Jun 14, 2023

@laurynas-biveinis , according to previous conversation, we may still need this mysql tablespace. Currently #1319 will fail if there is testcase using rocksdb DD.

@facebook-github-bot
Copy link

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@facebook-github-bot
Copy link

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@laurynas-biveinis
Copy link
Contributor

@sunshine-Chun , @luqun, It is true that we'll need the mysql tablespace. But, in the current prototype it is InnoDB that sets it up, thus at this point I am not comfortable to committing to RocksDB creating it. We could quickly merge a PR for ddse_dict_init, which would be mostly empty, and leave the tablespace for later.

facebook-github-bot pushed a commit that referenced this pull request Jun 17, 2023
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: #1297

Test Plan: CI

Differential Revision: D46700996

fbshipit-source-id: fbb8003
luqun pushed a commit to luqun/mysql-5.6 that referenced this pull request Jun 20, 2023
Summary:
 Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. 


Pull Request resolved: facebook#1297
GitHub Author: Chun Ni <[email protected]>

Test Plan: CI

Reviewers: luqun

Subscribers: [email protected]

Differential Revision: https://phabricator.intern.facebook.com/D46700996

Tags: accept2ship
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 3, 2023
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 18, 2023
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
@laurynas-biveinis
Copy link
Contributor

@sunshine-Chun , please close this PR

inikep pushed a commit to inikep/percona-server that referenced this pull request Dec 20, 2023
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook/mysql-5.6#1297

Test Plan: CI

Differential Revision: D46700996

fbshipit-source-id: fbb80035b54cc068c845e63fe6903c8488fce1d3
inikep pushed a commit to inikep/percona-server that referenced this pull request Dec 20, 2023
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook/mysql-5.6#1297

Test Plan: CI

Differential Revision: D46700996

fbshipit-source-id: fbb80035b54cc068c845e63fe6903c8488fce1d3
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 7, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 8, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 9, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 10, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 13, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 15, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 16, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 30, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 16, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 16, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 17, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 30, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 31, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 2, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 6, 2024
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants