Skip to content

fac25/Manoela-Karwan-sanitize-validate-challenge

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

1 Commit
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

Sanitization and validation challenge

Web applications commonly receive user input and display it on the page. For example a website like Twitter lets people submit messages that are then displayed to other people. It's very important to make sure you are receiving the right information, and that it does not contain any malicious code.

Setup

Make sure you have Git and Node (v18) installed.

  1. Clone this repo and cd into the directory
  2. Run npm install to install all the dependencies
  3. Run npm run dev to start the server.
    This uses the nodemon library to auto-restart the server when you save changes.

The server in challenge/server.js has two routes: GET / shows a form to create new posts and a list of existing posts. POST / creates a new post and redirects back to / so the list of posts updates.

Checking your work

Each challenge has associated unit tests. You can either run all the tests with npm test, or each individual challenge's tests with npm run test:sanitize and npm run test:validate.

Make sure you read test failures carefully—the output can be noisy but the error message should provide useful information to help you.

Sanitization

Displaying user-submitted information to other users can be dangerous. It's easy to end up vulnerable to an XSS attack ("Cross-Site Scripting"). This is where a malicious user puts some code inside a submitted string, hoping it will be displayed to another user, causing the browser to execute it.

For example if I submitted hello <script>alert("I am a hacker")</script> in a text input, and if the server naively embedded that on the page like this:

<h2>Comments</h2>
<ul>
  <li>Normal comment</li>
  <li>
    hello
    <script>
      alert("I am a hacker");
    </script>
  </li>
</ul>

The browser would execute that script tag. This is super dangerous as JavaScript running on the page can do quite a lot of damage (steal private information, mine Bitcoin etc).

You must always sanitize any user input that you want to template into an HTML page. A simple way to do this is replacing any characters that will trigger the browser's HTML-parsing, so that it instead treats the value as a regular string. For example replacing the < characters with the &lt; ("less-than") HTML entity will stop the browser executing a script tag, but will display the same.

Note that the simple approach is not enough stop an attacker—in a production app you should use a well-tested library for sanitization. Templating engines like Handlebars/React/Vue etc all handle sanitization automatically. We need to do it manually here as we are just using JS template literal strings.

Challenge 1: sanitization

Our server currently templates user input directly into the response HTML. This means the app is vulnerable to XSS attacks. Try submitting <script>alert("hacked")</script> in the message field. You need to fix this.

  1. Create a sanitize function that takes an input string and returns a safe sanitized version that cannot be interpreted as valid HTML
  2. Amend the postItem function in challenge/template.js to sanitize the user input

Validation

Your server will receive submissions that are missing information, or include information that is not valid. You cannot rely on client-side validation (like the required attribute on input elements), as this can easily be disabled with the browser dev tools. There are also lots of other ways to submit POST requests (e.g. using curl in the terminal).

You must always validate user submitted information on the server, otherwise your app can end up in an invalid state. E.g. if somebody signs up for an account but fails to provide a password, they could end up with an account that anyone can sign into.

Validation can be as simple as a series of if statements that return error responses to the user telling them what they did wrong. In a larger app you would probably user a validation library to make this easier.

Challenge 2: validation

Currently the form can be submitted with empty fields, which leads to a broken UI as a list item is rendered with no content.

  1. Edit the POST / handler to check that the values are not empty.
  2. If any values are missing respond with a 400 ("bad request") status code and re-send the home HTML template
  3. Edit the home function in challenge/templates.js to display an error message next to each missing field
  4. Stretch challenge: keep any previously submitted values in the inputs so the user doesn't have to re-type them

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published