Removing problem introduced by searching the configmap name again #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e that changed is already known in the caller function.
gralfca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for the configmap again inside the container update function introduces an error because all env vars corresponding to configmaps that didn't change are updated as well to the value of the config map that actually changed.
Consider a deployment object with a container in which
configmap.fabric8.io/update-on-change = cm1,cm2
Then modify cm1, and then modify cm2.
in the end both FABRIC8_CM1_CONFIGMAP and FABRIC8_CM2_CONFIGMAP could be set to the value of cm2.