Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to pass HTML form to FormData creation #117

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aronerben
Copy link
Contributor

@aronerben aronerben commented Feb 10, 2023

According to https://developer.mozilla.org/en-US/docs/Web/API/FormData/FormData, the constructor should be able to take an optional <form>/HTMLFormElement.

@aronerben
Copy link
Contributor Author

As it is, this introduces a cirular dependency between Browser.Dom and Browser.Blob (therefore this is a draft), how should this be resolved? Should I extract FormData into its own file?

@MangelMaxime
Copy link
Member

MangelMaxime commented Feb 10, 2023

I suppose the only clean way to resolve would be to merge Browser.Blob and Browser.Dom together.

But if we go this way I wonder, if you should not merge back all the packages together. This would be easier for the consumer too because if he wants to target the Browser he would only have 1 package to import.

I think the original split was to make designing the API/Packages easier and also perhaps a faster compilation. I think faster compilation is false good idea in this case.

@alfonsogarciacaro What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants