Fix calling an attached parametrized getter fails in transpiled javas…

…cript Fix #3494
fable-compiler · Aug 12, 2023 · a0f79ec · a0f79ec
1 parent 3662dfc
commit a0f79ec
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 1 deletion.
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -16,6 +16,16 @@
             "stopAtEntry": true,
             "console": "internalConsole"
         },
+        {
+            "name": "Quicktest - JavaScript",
+            "type": "coreclr",
+            "request": "launch",
+            "preLaunchTask": "build",
+            "program": "${workspaceFolder}/src/Fable.Cli/bin/Debug/net6.0/fable.dll",
+            "args": ["src/quicktest", "--exclude", "Fable.Core", "--noCache"],
+            "cwd": "${workspaceFolder}",
+            "console": "internalConsole"
+        },
         {
             "name": "Attach to Node",
             "port": 9229,

diff --git a/src/Fable.Cli/RELEASE_NOTES.md b/src/Fable.Cli/RELEASE_NOTES.md
@@ -1,6 +1,7 @@
 ### Unreleased
 
 * Fix #3480: Function decorated with `[<NamedParams>]` without arguments provided should take an empty object
+* Fix #3494: Calling an attached parametrized getter fails in transpiled javascript
 
 ### 4.1.4
 

diff --git a/src/Fable.Transforms/FSharp2Fable.Util.fs b/src/Fable.Transforms/FSharp2Fable.Util.fs
@@ -1832,11 +1832,19 @@ module Util =
             let arg = callInfo.Args |> List.tryHead |> Option.defaultWith makeNull
             Fable.Set(callee, Fable.FieldSet(info.name), membType, arg, r)
         else
+            // If the entity is decorated with AttachMembers, we need to remove the get/set prefix
+            // See https://github.com/fable-compiler/Fable/issues/3494
+            let membName =
+                if isAttachMembersEntity com entity then
+                    Naming.removeGetSetPrefix info.name
+                else
+                    info.name
+
             let entityGenParamsCount = entity.GenericParameters.Count
             let callInfo =
                 if callInfo.GenericArgs.Length < entityGenParamsCount then callInfo
                 else { callInfo with GenericArgs = List.skip entityGenParamsCount callInfo.GenericArgs }
-            getField callee info.name |> makeCall r typ callInfo
+            getField callee membName |> makeCall r typ callInfo
 
     let failReplace (com: IFableCompiler) ctx r (info: Fable.ReplaceCallInfo) (thisArg: Fable.Expr option) =
         let msg =

diff --git a/tests/Js/Main/JsInteropTests.fs b/tests/Js/Main/JsInteropTests.fs
@@ -256,6 +256,8 @@ type ClassWithAttachments(v, ?sign) =
     static member GreetingFormat = "Hello {0}"
     static member GetGrettingEnding(times, sign) = String.replicate times sign
     member _.WithSecretSauce(food) = $"{food} with lots of {secretSauce}"
+    member this.Add
+        with get(added : int) = x + added
 
 type ClassWithAttachmentsChild() =
     inherit ClassWithAttachments(3, "?")
@@ -320,6 +322,8 @@ let tests =
         equal 2 x.Times
         x.Times <- 3
         x.SaySomethingTo("Tanaka") |> equal "Hello Tanaka!!!!!"
+        // See https://github.com/fable-compiler/Fable/issues/3494
+        x.Add 2 |> equal 7
 
     testCase "Class with attached members can have static constructors" <| fun _ ->
         let x = ClassWithAttachments(2)