Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OBELAB to supported vendors #159

Merged
merged 2 commits into from
Oct 10, 2024
Merged

add OBELAB to supported vendors #159

merged 2 commits into from
Oct 10, 2024

Conversation

JMKIM-OBELAB
Copy link
Contributor

@JMKIM-OBELAB JMKIM-OBELAB commented Sep 30, 2024

Dear Collaborators,

We have recently released measurement tool and analysis tool fully compatible to snirf format using NIRSIT system.

I added OBELAB as a vendor supporting snirf data format.

If there's further information needed, I am happy support.

JMKIM-OBELAB and others added 2 commits September 30, 2024 16:31
Dear Collaborators,

We have recently released measurement tool and analysis tool fully compatible to snirf format using NIRSIT system. 

I added OBELAB as a vendor supporting snirf data format.
@HanBnrd
Copy link
Member

HanBnrd commented Oct 2, 2024

Thank you @JMKIM-OBELAB.

I've updated the word list to pass spell check tests.

@fNIRS/snirf_maintainers, do we need to test this with the validator?

@Horschig
Copy link
Collaborator

Thank you @JMKIM-OBELAB.

I've updated the word list to pass spell check tests.

@fNIRS/snirf_maintainers, do we need to test this with the validator?

Do you mean testing their OBELAB files with the validator? No, we never did this with any other vendor, also not with us.

Or do you mean checking if the repo is still intact? The spellcheck action should have checked that. So I think everything is fine here.

@HanBnrd
Copy link
Member

HanBnrd commented Oct 10, 2024

Yes, I was wondering if we should check vendor files before adding as supported in the specs.

Alright sounds good then.

@HanBnrd HanBnrd self-requested a review October 10, 2024 07:37
@HanBnrd HanBnrd merged commit 3cdc913 into fNIRS:master Oct 10, 2024
3 checks passed
@Horschig
Copy link
Collaborator

I think it's the vendor's responsibility to check whether their files really conform to the specs, it should not be our task (also e.g. in our case there are 100s of possible file types, like single device, multiple devices, with aux channels, without, etc, so it's a Herculean task without known device details).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants