Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1516: Enforced strict comparison between Limitation & Location path strings #263

Draft
wants to merge 1 commit into
base: 1.3
Choose a base branch
from

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue IBX-1516
Type bug
Target Ibexa version v3.3
BC breaks yes - ❗ it might cause previously valid values to be rejected ❗

Needs discussion

There is a mismatch between validation in Criterion and Limitation.

Criterion uses regex to check that Subtree Limitation is valid.
Subtree Limitation does not validate using this regex and "only" checks that Location path string and Limitation path string use the same beginning.

Early solution presented here ensures that values passed to Limition as path string is the same as the one present in Location (which ends with a trailing slash).

❗ However, because I'm not certain if they should be always exactly equal, I'm marking this as a BC break until discussed.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant