Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fatal error on empty @type string in ld+json verification. #403

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

andremacola
Copy link
Contributor

Urgent: Sorry, but there was a problem passing the @type value in the ld+json verification that was causing a fatal error. Currently, we only check a certain level and configuration of ld+json.

The issue is that some sites unify all entries into a single ld+json script tag and come as an array without the @type at the top level.

This has been resolved in this version. I am working to ensure that this functionality now supports multiple levels of LD Schema context.

I added a test example to avoid this in future releases.

Big sorry for that.

@ndaidong
Copy link
Collaborator

@andremacola thank you, let me see

@ndaidong ndaidong changed the base branch from main to 8.0.12 October 15, 2024 15:07
@ndaidong ndaidong merged commit 37cae76 into extractus:8.0.12 Oct 15, 2024
5 checks passed
ndaidong added a commit that referenced this pull request Oct 15, 2024
- Merge pr #403 by @andremacola
@ndaidong ndaidong mentioned this pull request Oct 15, 2024
@ndaidong
Copy link
Collaborator

@andremacola thank you for your quick update. Please double check v8.0.12 I've just released.

@ndaidong ndaidong mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants