Skip to content

Commit

Permalink
feat: Try to grab the date from the URL before going to the secondary…
Browse files Browse the repository at this point in the history
… elements.
  • Loading branch information
andremacola committed Oct 23, 2024
1 parent 6355d23 commit 2739855
Show file tree
Hide file tree
Showing 4 changed files with 116 additions and 22 deletions.
2 changes: 1 addition & 1 deletion src/utils/extractMetaData.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export default (html) => {
const metadata = extractLdSchema(doc, entry)

if (!metadata.published) {
metadata.published = findDate(doc) || ''
metadata.published = findDate(doc, metadata) || ''
}

return metadata
Expand Down
9 changes: 7 additions & 2 deletions src/utils/extractMetaData.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,25 @@ describe('test extractMetaData', () => {
it('test extractMetaData(find date)', async () => {
const html1 = readFileSync('./test-data/regular-article-date-time.html', 'utf8')
const html2 = readFileSync('./test-data/regular-article-date-itemprop.html', 'utf8')
const html3 = readFileSync('./test-data/regular-article-date-span.html', 'utf8')
const html3 = readFileSync('./test-data/regular-article-date-url.html', 'utf8')
const html4 = readFileSync('./test-data/regular-article-date-span.html', 'utf8')
const result1 = extractMetaData(html1)
const result2 = extractMetaData(html2)
const result3 = extractMetaData(html3)
const result4 = extractMetaData(html4)
assert.ok(isObject(result1))
assert.ok(isObject(result2))
assert.ok(isObject(result3))
assert.ok(isObject(result4))
keys.forEach((k) => {
assert.ok(hasProperty(result1, k))
assert.ok(hasProperty(result3, k))
assert.ok(hasProperty(result3, k))
assert.ok(hasProperty(result4, k))
})
assert.ok(isDateString(result1.published))
assert.ok(isDateString(result2.published))
assert.ok(isDateString(result3.published))
assert.ok((isDateString(result3.published)))
assert.ok(isDateString(result4.published))
})
})
72 changes: 53 additions & 19 deletions src/utils/findDate.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@

/**
* Convert date format to YYYY-MM-DD
*
* @param {string} dateString
* @returns {string} YYYY-MM-DD
*/
* Convert date format to YYYY-MM-DD
*
* @param {string} dateString
* @returns {string} YYYY-MM-DD
*/
function convertDateFormat (dateString) {
const parts = dateString.split('/')
if (parts.length !== 3) return dateString
Expand All @@ -22,34 +22,68 @@ function convertDateFormat (dateString) {
}

/**
* Look for the publication date in the body of the content.
*
* @param {Document} document - The HTML Document
* @returns {string} The date string
*/
export default function (doc) {
* @param {string} url
* @returns {string|undefined}
*/
function dateFromUrl (url) {
const regex = /\/(\d{4})\/(\d{2})\/(\d{2})(?:[^\d]|$)/
const match = url.match(regex)

if (match) {
// eslint-disable-next-line no-unused-vars
const [_, year, month, day] = match
const dateString = `${year}-${month}-${day}T00:00:00`

// date validation
const date = new Date(dateString)
if (date.getFullYear() === parseInt(year) &&
date.getMonth() + 1 === parseInt(month) &&
date.getDate() === parseInt(day)) {
return dateString
}
}

return undefined
}

/**
* @param {Element} element
* @returns {string|undefined}
*/
function dateFromContent (element) {
const datePatterns = [
/\d{4}-\d{2}-\d{2}/,
/\d{1,2}\/\d{1,2}\/\d{2,4}/,
]

const findDate = (element) => {
for (const pattern of datePatterns) {
const match = element.textContent.match(pattern)
if (match) return convertDateFormat(match[0])
}
return ''
for (const pattern of datePatterns) {
const match = element.textContent.match(pattern)
if (match) return convertDateFormat(match[0])
}

return undefined
}

/**
* Look for publication date in the body of the content.
*
* @param {Document} document - HTML Document
* @param {Object} metadata - Article metadata
* @returns {string} Date string
*/
export default function (doc, metadata) {
const priorityElements = doc.querySelectorAll('time, [datetime], [itemprop~=datePublished], [itemprop~=dateCreated]')
for (const el of priorityElements) {
const date = el.getAttribute('datetime') || el.getAttribute('content') || findDate(el)
const date = el.getAttribute('datetime') || el.getAttribute('content') || dateFromContent(el)
if (date) return date
}

const urlDate = dateFromUrl(metadata.url)
if (urlDate) return urlDate

const secondaryElements = doc.querySelectorAll('p, span, div')
for (const el of secondaryElements) {
const date = findDate(el)
const date = dateFromContent(el)
if (date) return date
}

Expand Down
55 changes: 55 additions & 0 deletions test-data/regular-article-date-url.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
<!doctype html>
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Article title here - ArticleParser</title>
<meta name="author" content="Alice">
<meta name="description" content="Few words about this article">
<meta name="keywords" content="alpha, beta, gamma">
<meta name="twitter:site" content="@ArticleParser">
<meta name="twitter:url" content="https://somewhere.com/2024/02/11/path/to/article-title-here">
<meta name="twitter:card" content="summary_large_image">
<meta name="twitter:image" content="https://somewhere.com/2024/02/11/path/to/image.jpg">
<meta name="twitter:creator" content="@alice">
<meta property="og:title" content="Article title here">
<meta property="og:type" content="article">
<meta property="og:url" content="https://somewhere.com/2024/02/11/path/to/article-title-here">
<meta property="og:description" content="Navigation here Few can name a rational peach that isn't a conscientious goldfish! One cannot separate snakes from plucky pomegranates? Draped neatly on a hanger, the melons could be said to resemble knowledgeable pigs.">
<meta property="og:image" content="https://somewhere.com/path/to/image.jpg">

<link rel="stylesheet" href="/path/to/cssfile.css">
<link rel="canonical" href="https://somewhere.com/2024/02/11/path/to/article-title-here">
<link rel="amphtml" href="https://m.somewhere.com/2024/02/11/path/to/article-title-here.amp">
<link rel="shortlink" href="https://sw.re/419283">
<link rel="icon" href="https://somewhere.com/favicon.ico">

<link rel="alternate" title="ArticleParser" type="application/atom+xml" href="https://somewhere.com/atom.xml">

<link rel="manifest" href="/manifest.json">
</head>
<body>
<header>Page header here</header>
<main>
<section>
<nav>Navigation here</nav>
</section>
<section>
<h1>Article title here</h1>
<article>
<div class="contentdetail">Few can name a <a href="https://otherwhere.com/descriptions/rational-peach">rational peach</a> that isn't a conscientious goldfish! One cannot separate snakes from plucky pomegranates? Draped neatly on a hanger, the melons could be said to resemble knowledgeable pigs. Some posit the enchanting tiger to be less than confident. The literature would have us believe that an impartial turtle is not but a hippopotamus. Unfortunately, that is wrong; on the contrary, those cows are nothing more than pandas! The chicken is a shark; A turtle can hardly be considered a kind horse without also being a pomegranate. Zebras are witty persimmons.</div>
<p class="contentdetail">
Those cheetahs are nothing more than dogs. A <a href="/dict/watermelon">watermelon</a> is an exuberant kangaroo. An octopus is the tangerine of a grapes? The cherry is a shark. Recent controversy aside, they were lost without the cheerful plum that composed their fox. As far as we can estimate, one cannot separate camels from dynamic hamsters. Those tigers are nothing more than cows! A cow is a squirrel from the right perspective. Their banana was, in this moment, a helpful bear.</p>
<p>The first fair dog is, in its own way, a lemon.</p>
<address>4746 Kelly Drive, West Virginia</address>
<img src="./orange.png" style="border: solid 1px #000">
</article>
</section>
<section class="sidebar-widget">
<widget>Some widget here</widget>
<widget>Some widget here</widget>
</section>
</main>
<footer>Page footer here</footer>
</body>
</html>

0 comments on commit 2739855

Please sign in to comment.