-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description to each page (#1639) #1672
Add description to each page (#1639) #1672
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
_posts/2024-07-16-welcome-post.md
Outdated
@@ -1,5 +1,6 @@ | |||
--- | |||
title: Welcome to The Express Blog! | |||
title: Welcome to The Express Blog! | |||
description: Introducing the new Express blog—a primary platform for announcements, updates, and communication from the Express technical committee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introducing the new Express blog — a
primary platform for announcements, updates, and communication from the Express technical committee.
en/3x/api.md
Outdated
@@ -1,6 +1,7 @@ | |||
--- | |||
layout: 3x-api | |||
title: Express 3.x - API Reference | |||
description: Access the API reference for Express.js version 3.x, noting that this version is end-of-life and no longer maintained; includes details on modules and methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintained - inclu
des details on mod
en/4x/api.md
Outdated
@@ -1,6 +1,7 @@ | |||
--- | |||
layout: 4x-api | |||
title: Express 4.x - API Reference | |||
description: Access the comprehensive API reference for Express.js 4.x, detailing all modules, methods, and properties for building web applications with this version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Access the API reference for Express.js 4.x, detailing all modules, methods, and properties for building web applications with this version.
en/5x/api.md
Outdated
@@ -1,6 +1,7 @@ | |||
--- | |||
layout: 5x-api | |||
title: Express 5.x - API Reference | |||
description: Access the comprehensive API reference for Express.js 5.x, detailing all modules, methods, and properties for building web applications with this latest version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Access the API reference for Express.js 5.x, detailing all modules, methods, and properties for building web applications with this latest version.
en/api.md
Outdated
@@ -1,6 +1,7 @@ | |||
--- | |||
layout: 4x-api | |||
title: Express 4.x - API Reference | |||
description: Access the comprehensive API reference for Express.js 4.x, detailing all modules, methods, and properties for building web applications with this version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Access the API reference for Express.js detailing all modules, methods, and properties for building web applications with this version.
en/guide/routing.md
Outdated
@@ -1,6 +1,7 @@ | |||
--- | |||
layout: page | |||
title: Express routing | |||
description: Learn how to define and use routes in Express.js applications, including route methods, route paths, parameters, and using express.Router for modular routing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Learn how to define and use routes in Express.js applications, including route methods, route paths, parameters, and using Router for modular routing.
en/starter/static-files.md
Outdated
@@ -1,6 +1,7 @@ | |||
--- | |||
layout: page | |||
title: Serving static files in Express | |||
description: Understand how to serve static files like images, CSS, and JavaScript in Express.js applications using the built-in express.static middleware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understand how to serve static files like images, CSS, and JavaScript in Express.js applications using the built-in 'static' middleware.
We would have to add a description page in other languages, even if it is in English. |
Hi @carlosstenzel , can you please elaborate what you mean by that? Does this mean adding description tag (like I did in the en folder) in all other language folders? @bjohansebas , please let me know your thoughts |
Hi @carlosstenzel , do you want me to remove description tag from /en/blog/posts.md file? |
@carlosstenzel For the blog posts, the description was in the original page design but was removed before it was released. |
I added the images just for viewing and analysis by others. tks |
@rehmansheikh222 please do it, exactly as you said—doing the same in the other folders |
Hi @bjohansebas , just one last thing, does the description need to be in english (for other languages folder)? |
@rehmansheikh222 Yes, in English |
@carlosstenzel please check and let me know if there is anything else you would like me to change/add |
I don't think it's ok ;) |
Can you please elaborate? |
sorry *** I think it's ok |
Oh, okay. So, do you think you can approve the PR now? |
@carlosstenzel it still says one review is required for the merging :) |
@bjohansebas @crandmck @UlisesGascon could you help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@rehmansheikh222 thanks |
I'm glad I could contribute in some way, this was my first issue for open source and I plan to contribute more. Thanks all of you guys, you were really helpful. |
* Add description to each page (expressjs#1639) * fix: rersolved description issues and also added the descriptions in the es folder * feat: added descriptions in all the languages
@rehmansheikh222 we have a documentation group, maybe you want to join and help us. see #1506 |
Yes sure, I will keep an eye on it. Thanks bro |
Added concise descriptions to each page in the en folder.