-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation working group #1506
Comments
Yeah I'll help with this! |
Hi @crandmck ! I'll also try to help with this :) |
Welcome! |
As promised, I changed the name of the team to @expressjs/docs-wg |
I also want to work on this |
congratulations @chrisdel101 @inigomarquinez |
I want to join |
Welcome @bjohansebas ! |
Thanks for this opportunity |
I want to join too _ |
Welcome @carlosstenzel ! |
I think we should add a changes to the contributing page stating that features should be proposed and approved first via issues, before they are made as PRs. This is because people are putting in effort with great intentions, but then sometimes their work does not match with an immediate need in the application and cannot be used. Nobody likes to have wasted time on a PR that doesn't get merged. Maybe we can make this clear in the CONTRIBUTING.md? Just wanted to see if there was consensus. |
I think that's a great idea, @chrisdel101 ... something that has indeed come up repeatedly. I just haven't had the bandwidth to address it, so I would appreciate it if you would! Also, I think we should either link to or incorporate the contents of https://github.com/expressjs/expressjs.com/blob/gh-pages/CONTRIBUTING.md into a "Contributing to documentation" section in https://expressjs.com/en/resources/contributing.html. |
@crandmck I would love to join this team. This year I discovered the hobby of contributing to open source projects and it feels rewarding to have your code used by thousands of people. I recently contributed bugfixes and translations for the official documentation repositories of React, Docker, and Quicksilver where my PRs were merged. I hope to help a lot if they manage to accept me. |
@juliogarciape I merged your PR #1618 and I'll invite you to the docs wg. |
Thank you very much, I love Express.js |
Congrats to @bjohansebas as the newest repo captain! |
We have an existing team @expressjs/expressjs-com-collaborators for people who want to help with Express docs and which has triage rights in the repo.
I'd like to invite @chrisdel101 and @inigomarquinez to join this team, as they recently had PRs merged. Please reply in the comments to this issue if you're interested and I'll add you!
Anyone else who has recently had a PR merged is also welcome--please just speak up. As we land PRs from others, we can invite them as well.
Also--the current team name
expressjs/expressjs-com-collaborators
is somewhat unwieldy and doesn't come up easily in the GH typeahead match. So I'd like to change the name of the team toexpressjs/docs-wg
. I don't imagine that anyone will object to that, but I'll wait a while before renaming it to make sure.The text was updated successfully, but these errors were encountered: